fix: parse Map key types containing commas - #1941
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
fallintoplace
force-pushed
the
fix/map-nested-key-type-parsing
branch
from
July 30, 2026 17:40
2685027 to
43e4cf2
Compare
fallintoplace
force-pushed
the
fix/map-nested-key-type-parsing
branch
from
July 30, 2026 17:59
43e4cf2 to
dcf8a4c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow
Mapkey types to contain commas in nested parameters. For example, the driver now parses this valid type correctly:Problem
Map.parsesplit key and value types at the first comma. For the example above, it treatedDateTime64(3as the key type and failed before any query could run. The existing Enum-specific workaround covered only one form of nested comma.Fix
Find the first top-level comma while ignoring nested parentheses and quoted content. This handles parameterized key types generally, preserves Enum labels containing parentheses, and removes the Enum special case. The parsing flow was also flattened so invalid and non-comparable key types return early.
Tests
Unit coverage includes:
DateTime64keys with timezone parameters)go test ./...Checklist