fix: preserve sql.NullBool values in columnar appends - #1954
Open
fallintoplace wants to merge 1 commit into
Open
fix: preserve sql.NullBool values in columnar appends#1954fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Columnar appends of
[]sql.NullBooland[]*sql.NullBoolwere recursively calling the bulk append method and ignoring its errors. This could leave the value column with zero rows while returning nil, and invalid values were not marked in the NULL bitmap.This change uses
AppendRow, preserves the NULL bitmap, and safely handles nil*sql.NullBoolvalues.Testing
go test ./... -count=1go vet ./lib/column