Update Poco to version 1.14.2 #528
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I ran into an unexpected issue while reviewing this PR. Please try again later. |
slabko
force-pushed
the
poco_update_1.14.2
branch
from
b703961 to
631fd48
Compare
This is a cherry-pick of commit 900d0e0 900d0e0 This change works around a double-free of Poco::EnvironmentImpl::_map by moving the static variable into a function-local static. Note: this does not address the underlying issue that causes the double-free. The root cause likely occurs only when sanitizers are enabled. Specifically, when sanitizers are enabled, the visibility of the ODBC shared library is set to default. Both the shared library (libclickhouseodbc) and the integration test executable statically link Poco and libclickhouse-odbc-impl. As a result, when the integration tests load the shared library, both the executable and the library share static variables and both attempt to delete them at process exit, leading to a double-free.
slabko
force-pushed
the
poco_update_1.14.2
branch
from
631fd48 to
5d66fb1
Compare
|
I ran into an unexpected issue while reviewing this PR. Please try again later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.