-
Notifications
You must be signed in to change notification settings - Fork 129
feat: microbatch strategy #404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@BentsiLeviav may I ask for a review on this? it would be an important addition for our pipelines |
Hi @canbekley I'll review this in the next following days. |
Hi, that's a great feature - thanks for implementing it! I don't quite understand the logic behind requiring Wouldn't it make more sense to either remove this restriction or implement it using In Snowflake, Since ClickHouse struggles when handling a large number of complex mutations (my experience), I assume it would be better to go with |
4f99c6e
to
4041b02
Compare
@pheepa I don't see where the I opted for |
@canbekley I'm sorry, the refactoring of the incremental strategy validation confused me a little bit (but as an adapter method it makes more sense). Now it looks good to me. |
hi @BentsiLeviav, I've added documentation and fixed an issue with previous python versions. could you have a second look? |
@BentsiLeviav Do you maybe have an idea how to circumvent this check in MicrobatchModelRunner._is_incremental(), which currently prevents |
69bc361
to
91fc08e
Compare
Hi, is there any update on this? I believe this feature is waiting for review :) |
Adds support for the incremental "microbatch" strategy #398, that comes with dbt-core 1.9.0 #403
Currently only works for non-distributed incremental model, as dbt-core has hard-coded config.materialization = 'incremental' into a microbatching condition. Maybe this can be patched by the adapater though?
Checklist