Skip to content

Conversation

@koletzilla
Copy link
Contributor

@koletzilla koletzilla commented Sep 11, 2025

Summary

This PR adds back cloud tests so it will be executed on PRs again. I feel like they are now in a good enough shape to start executing them also in PRs. It also tests with the new CH Cloud cluster which is more stable than the other one.

Pending things:

  • Fix ClickHouse cloud tests #458: This issue should be closed a few days after we merge this PR, but lets wait a bit in case we found other problematic tests.
  • Improve test performance #532: We need to also test with other python versions. Testing with other versions is currently not the most problematic thing as we do test them in test_matrix, but it would be nice to also have these tests here. We may add these other python versions once we optimise the tests so they run faster or at least they can run concurrently.

Note

Re-enables Cloud testing in CI and makes tests compatible with Cloud limitations.

  • CI: Update test_cloud.yml to trigger on PRs to main and set a timeout-minutes: 50 for cloud_smt_tests.
  • Tests: Conditionally skip distributed/replicated constraints suites (TestDistributed*ContractColumnsEqual) when DBT_CH_TEST_CLOUD is true, since replicated tables aren’t supported in Cloud; add os import to support skip logic.

Written by Cursor Bugbot for commit 234d749. This will update automatically on new commits. Configure here.

Comment on lines +189 to +192
@pytest.mark.skipif(
os.environ.get('DBT_CH_TEST_CLOUD', '').lower() in ('1', 'true', 'yes'),
reason='Replicated is not supported for cloud',
)
Copy link
Contributor Author

@koletzilla koletzilla Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those test were added in #575 but they fail in cloud. The issue is that they test Distributed tables and we cannot test them for cloud. They raise this error:

14:02:16    Compilation Error in model my_model_wrong_order (models/my_model_wrong_order.sql)
  To use distributed materialization cluster setting in dbt profile must be set
  
  > in macro materialization_distributed_table_clickhouse (macros/materializations/distributed_table.sql)
  > called by model my_model_wrong_order (models/my_model_wrong_order.sql)

Skipping them.

@koletzilla koletzilla marked this pull request as ready for review January 15, 2026 15:17
@koletzilla koletzilla merged commit 055c3f6 into main Jan 15, 2026
16 checks passed
@koletzilla koletzilla deleted the fix-cloud-tests-v2 branch January 15, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants