Skip to content

Feat/private cidr labels #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

barryrobison
Copy link
Contributor

No description provided.

@barryrobison barryrobison force-pushed the feat/private-cidr-labels branch from 2270c5e to 038ff32 Compare February 15, 2025 06:21
@andreev-io
Copy link
Collaborator

Hi Barry! Apologies that I haven't helped you with the other PR yet – it's on my TODO list. Just curious in the meantime, did kubenetmon work for your tests?

@barryrobison
Copy link
Contributor Author

Hi Barry! Apologies that I haven't helped you with the other PR yet – it's on my TODO list. Just curious in the meantime, did kubenetmon work for your tests?

Oh no worries - I built the image locally in our pipeline and it successfully runs on both architectures. Something is wrong with the integration tests but I haven't had time to sus out what yet.

And sorry I didn't intend to push this PR to your repo yet, I'm still fleshing out the additional metadata and will add README instructions before I ask for your review.

Thanks!

@andreev-io andreev-io force-pushed the feat/private-cidr-labels branch from 038ff32 to 234d0f1 Compare February 17, 2025 18:53
@andreev-io
Copy link
Collaborator

Just FYI I merged your other change with ARM images and resolved issues with CI. Hope this helps you with developing this patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants