Conversation
Inspect the host name and port to determine whether to make a TLS connection to ClickHouse. The new internal function `ch_is_cloud_host()` returns a value other than `0` if the host name argument is a ClickHouse cloud host, matching any of the ClickHouse cloud environment host names. For binary connections, set the port to the ClickHouse secure port if `ch_is_cloud_host()` returns true for the host name and enable TLS if the port, whether explicitly specified for the connection or set by matching the host name, is the ClickHouse secure port. For HTTP connections, set the port to the ClickHouse TLS HTTP port if `ch_is_cloud_host()` returns true for the host name. Then set the URL scheme to "https" if the port, whether explicitly specified for the connection or set by matching the host name, is the ClickHouse TLS secure port or the standard HTTPS port. Tested both patterns against a `.clickhouse.cloud` host name and used it to successfully import a schema. In passing, remove a debugging `printf` statement from `.github/ubuntu/clickhouse.sh` and a duplicate library argument to `SHLIB_LINK` in the `Makefile`.
serprex
approved these changes
Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspect the host name and port to determine whether to make a TLS connection to ClickHouse. The new internal function
ch_is_cloud_host()returns a value other than0if the host name argument is a ClickHouse cloud host, matching any of the ClickHouse cloud environment host names.For binary connections, set the port to the ClickHouse secure port if
ch_is_cloud_host()returns true for the host name and enable TLS if the port, whether explicitly specified for the connection or set by matching the host name, is the ClickHouse secure port.For HTTP connections, set the port to the ClickHouse TLS HTTP port if
ch_is_cloud_host()returns true for the host name. Then set the URL scheme to "https" if the port, whether explicitly specified for the connection or set by matching the host name, is the ClickHouse TLS secure port or the standard HTTPS port.Tested both patterns against a
.clickhouse.cloudhost name and used it to successfully import a schema.In passing, remove a debugging
printfstatement from.github/ubuntu/clickhouse.shand a duplicate library argument toSHLIB_LINKin theMakefile.