Conversation
theory
added
data types
The new version adds a `Bool` column type and the `-DCH_MAP_BOOL_TO_UINT8=OFF` compile directive to prevent converting bools to `uint8` values. This eliminates the need for the binary driver to cast to and from `uint8` (`INT2`) to handle boolean values: we can just directly use the boolean type support.
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new version adds a
Boolcolumn type and the-DCH_MAP_BOOL_TO_UINT8=OFFcompile directive to prevent converting bools touint8values. This eliminates the need for the binary driver to cast to and fromuint8(INT2) to handle boolean values: we can just directly use the boolean type support.