Skip to content

Fix gaps in clickhouse-c driver#260

Merged
serprex merged 1 commit into
mainfrom
chc-fixes
May 28, 2026
Merged

Fix gaps in clickhouse-c driver#260
serprex merged 1 commit into
mainfrom
chc-fixes

Conversation

@serprex

@serprex serprex commented May 28, 2026

Copy link
Copy Markdown
Member

Verify TLS certificates
Fix LowCardinality(Nullable(String)) INSERT crash
Fix DateTime64 sub-second precision for scale > 6
Reject NaN/Infinity on Decimal INSERT

Update clickhouse-c with fixes around overflow detection

@serprex serprex requested a review from theory May 28, 2026 20:33

@theory theory left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

I think it may be time to list you as an author.

INSERT INTO null_vals VALUES(
1, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, -- NULL,
NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! I forgot all about this.

Comment thread README.md Outdated
* [David E. Wheeler](https://justatheory.com/)
* [Ildus Kurbangaliev](https://github.com/ildus)
* [Ibrar Ahmed](https://github.com/ibrarahmad)
* [serprex](https://github.com/serprex)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My dude, we've been referring to you by your full name in CHANGELOG.md 😂. Make your name first or second.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed changelog

Comment thread CHANGELOG.md
ClickHouse block for reduced memory consumption. It also greatly reduces
build time and the size of the library by over 75%. Thanks to Philip Dubé
for the the new library and the PR ([#254]).
build time and the size of the library by over 75%. Thanks to serprex for

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL seriously?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

growing up terminally online does a number on handle association

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tell me about it

Verify TLS certificates
Fix LowCardinality(Nullable(String)) INSERT crash
Fix DateTime64 sub-second precision for scale > 6
Reject NaN/Infinity on Decimal INSERT

Update clickhouse-c with fixes around overflow detection
@serprex serprex merged commit e6ab3d5 into main May 28, 2026
22 checks passed
@serprex serprex deleted the chc-fixes branch May 28, 2026 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants