feat: add GCP PSC Service Attachment support for RPEs#512
Draft
EvandroLG wants to merge 5 commits into
Draft
Conversation
Contributor
|
@ClickHouse/clickpipes This PR has been tagged as ClickPipes-related. |
There was a problem hiding this comment.
Pull request overview
Adds support for creating ClickPipes Reverse Private Endpoints (RPEs) using GCP Private Service Connect (PSC) Service Attachments.
Changes:
- Introduces new RPE type
GCP_PSC_SERVICE_ATTACHMENTand wires it into allowed type validation. - Adds
gcp_service_attachmentto the Terraform resource schema/model and maps it into the create request + state/read handling. - Updates generated resource docs to include the new type/attribute.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/resource/models/clickpipe_reverse_private_endpoint_resource.go | Adds gcp_service_attachment to the Terraform state model. |
| pkg/resource/clickpipe_reverse_private_endpoint.go | Extends schema/type validation, adds create request mapping and read/state mapping for GCP PSC service attachment. |
| pkg/internal/api/clickpipe_reverse_private_endpoint_models.go | Adds gcpServiceAttachment to the API create payload/embedded model. |
| pkg/internal/api/clickpipe_reverse_private_endpoint.go | Adds new API constant/type entry for GCP_PSC_SERVICE_ATTACHMENT. |
| docs/resources/clickpipes_reverse_private_endpoint.md | Updates generated docs schema section for the new type and attribute. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
whites11
reviewed
Apr 17, 2026
whites11
approved these changes
Apr 17, 2026
Member
whites11
left a comment
whites11
left a comment
There was a problem hiding this comment.
one suggestion, otherwise looks good
jkaflik
approved these changes
Apr 20, 2026
Member
jkaflik
left a comment
jkaflik
left a comment
There was a problem hiding this comment.
LGTM. As we discussed internally, let's hold with the merge until the release day.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GCP_PSC_SERVICE_ATTACHMENTas a supported type forclickhouse_clickpipes_reverse_private_endpoint, with a new optionalgcp_service_attachmentattribute (format:
projects/{project}/regions/{region}/serviceAttachments/{name}).