Skip to content

Conversation

@mathiasbio
Copy link
Collaborator

@mathiasbio mathiasbio commented Oct 1, 2025

Description

Ensuring numpy in cnvpytor is pinned to version 1.23.5

Added

  • [Description]

Changed

  • [Description]

Fixed

  • [Description]

Removed

  • [Description]

Documentation

  • N/A
  • Updated Balsamic documentation to reflect the changes as needed for this PR.
    • [Document Name]

Tests

Feature Tests

  • N/A
  • Test [Description]
    • [Screenshot]

Pipeline Integrity Tests

  • Report deliver (generation of the .hk file)
    • N/A
    • Verified
  • TGA T/O Workflow
    • N/A
    • Verified
  • TGA T/N Workflow
    • N/A
    • Verified
  • UMI T/O Workflow
    • N/A
    • Verified
  • UMI T/N Workflow
    • N/A
    • Verified
  • WGS T/O Workflow
    • N/A
    • Verified
  • WGS T/N Workflow
    • N/A
    • Verified
  • QC Workflow
    • N/A
    • Verified
  • PON Workflow
    • N/A
    • Verified

Clinical Genomics Stockholm

Documentation

  • Atlas documentation
    • N/A
    • Updated: [Link]
  • Web portal for Clinical Genomics
    • N/A
    • Updated: [Link]

Panel of Normal specific criteria

User Changes

  • N/A
  • This PR affects the output files or results.
    • User feedback is considered unnecessary because [Justification].
    • Affected users have been included in the development process and given a chance to provide feedback.

Infrastructure Changes

  • Stored files in Housekeeper
    • N/A
    • Updated: [Link]
  • CG (CLI and delivered/uploaded files)
    • N/A
    • Updated: [Link]
  • Servers (configuration files on Hasta)
    • N/A
    • Updated: [Link]
  • Scout interface
    • N/A
    • Updated: [Link]

Validation criteria

Validation criteria to be added to validation report PR: [LINK-TO-VALIDATION-REPORT-PR from the validations repository]

Version specific criteria

  • Text here or N/A

Important

One of the below checkboxes for validation need to be checked

  • Added version specific validation criteria to validation report
  • Changes validated in standard sections: [validation-section]
  • Validation criteria not necessary

Checklist

Important

Ensure that all checkboxes below are ticked before merging.

For Developers

  • PR Description
    • Provided a comprehensive description of the PR.
    • Linked relevant user stories or issues to the PR.
  • Documentation
    • Verified and updated documentation if necessary.
  • Validation criteria
    • Completed the validation criteria section of the template.
  • Tests
    • Described and tested the functionality addressed in the PR.
    • Ensured integration of the new code with existing workflows.
    • Confirmed that meaningful unit tests were added for the changes introduced.
    • Checked that the PR has successfully passed all relevant code smells and coverage checks.
  • Review
    • Addressed and resolved all the feedback provided during the code review process.
    • Obtained final approval from designated reviewers.

For Reviewers

  • Code
    • Code implements the intended features or fixes the reported issue.
    • Code follows the project's coding standards and style guide.
  • Documentation
    • Pipeline changes are well-documented in the CHANGELOG and relevant documentation.
  • Validation criteria
    • The author has completed the validation criteria section of the template
  • Tests
    • The author provided a description of their manual testing, including consideration of edge cases and boundary
      conditions where applicable, with satisfactory results.
  • Review
    • Confirmed that the developer has addressed all the comments during the code review.

@codecov
Copy link

codecov bot commented Oct 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.33%. Comparing base (dfd1748) to head (0092b0f).
⚠️ Report is 1 commits behind head on release_v18.0.0.

Additional details and impacted files
@@               Coverage Diff                @@
##           release_v18.0.0    #1617   +/-   ##
================================================
  Coverage            99.33%   99.33%           
================================================
  Files                   40       40           
  Lines                 1960     1960           
================================================
  Hits                  1947     1947           
  Misses                  13       13           
Flag Coverage Δ
unittests 99.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mathiasbio mathiasbio marked this pull request as ready for review October 1, 2025 07:52
@mathiasbio mathiasbio requested a review from a team as a code owner October 1, 2025 07:52
@mathiasbio mathiasbio changed the title fix cnvpytor container fix: cnvpytor container Oct 1, 2025
@mathiasbio mathiasbio linked an issue Oct 1, 2025 that may be closed by this pull request
@mathiasbio mathiasbio self-assigned this Oct 1, 2025
Copy link
Contributor

@fevac fevac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix! however this dockerfile is so messy and needs a bit of love. Let's clean it up for the next version

@fevac
Copy link
Contributor

fevac commented Oct 1, 2025

there is also a quality issue, please fix it before merging

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 1, 2025

@mathiasbio mathiasbio merged commit b5b5702 into release_v18.0.0 Oct 1, 2025
25 checks passed
@mathiasbio mathiasbio deleted the fix_numpy_cnvpytor branch October 1, 2025 12:42
@mathiasbio mathiasbio mentioned this pull request Oct 14, 2025
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] cnvpytor fails with numpy >2

3 participants