Feature: add FaceRepository that does facial recognition#9
Merged
YifanZhang05 merged 5 commits intomainfrom Nov 25, 2025
Merged
Feature: add FaceRepository that does facial recognition#9YifanZhang05 merged 5 commits intomainfrom
YifanZhang05 merged 5 commits intomainfrom
Conversation
Contributor
Author
|
added chunk faces connector that stores face information for each chunk in modal dict The dict structure looks like this: |
eshaan-mehta
approved these changes
Nov 25, 2025
Contributor
eshaan-mehta
left a comment
There was a problem hiding this comment.
LGTM in terms of functionality, but should make another ticket for testing
| @@ -0,0 +1,18 @@ | |||
| import os | |||
Contributor
There was a problem hiding this comment.
should add more unit tests for each of the functions. It's ok for now, but you should add this as a next step as another PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key features
FaceRepositoy.add_faces(self, namespace: str, chunk_id: str, faces: list[Face]):
add the given face embeddings to Pinecone under namespace, with chunk_id (which video chunk the embedded face appears in) and face_id (which face it is) in metadata.
returns a dictionary where key is face_id, value is number of times appearing
add_images(self, namespace: str, chunk_id: str, img_lst: list):
first detect all faces from each image in img_lst, then call add_faces
returns a dictionary where key is face_id, value is number of times appearing