This repository was archived by the owner on Jul 6, 2020. It is now read-only.
update signup component #236
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in response to Cloud-CV#235
Codecov Report
@@ Coverage Diff @@
## master #236 +/- ##
=======================================
Coverage 51.73% 51.73%
=======================================
Files 66 66
Lines 3659 3659
Branches 413 413
=======================================
Hits 1893 1893
Misses 1671 1671
Partials 95 95Continue to review full report at Codecov.
|
krtkvrm
reviewed
Dec 11, 2019
| @@ -51,7 +51,7 @@ | |||
| <i *ngIf="authService.canShowPassword" class="fa fa-eye-slash pointer"></i> | |||
| </span> | |||
| <label for="password" [class.active]="ispasswordFocused"> | |||
| <strong>Password-minlength:8 required</strong> | |||
| <strong>Password</strong> | |||
There was a problem hiding this comment.
How about changing this to
Password (minimum 8 Characters)
|
Hi @amanex007 Can you make a single PR for both. (ie single pr for #235 and #236) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in response to #235
Fixes #
Changes proposed in this pull request: