This repository was archived by the owner on Jul 6, 2020. It is now read-only.
Add a soft check when editing phase details #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of a Google Code-In task. #### Changes proposed: * Include a soft-check so that: max submissions/day > max number of submissions/month > Max total submissions
Codecov Report
@@ Coverage Diff @@
## master #265 +/- ##
==========================================
- Coverage 50.62% 50.51% -0.11%
==========================================
Files 66 66
Lines 3761 3771 +10
Branches 442 444 +2
==========================================
+ Hits 1904 1905 +1
- Misses 1762 1771 +9
Partials 95 95
Continue to review full report at Codecov.
|
Ram81
suggested changes
Jan 8, 2020
There was a problem hiding this comment.
@nikochiko changes look good to me, can you share screenshot of the working?
|
@Ram81 I am facing this issue for the dev build 😕 (Not linking issue directly as it could create reference to the unrelated issue) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of a Google Code-In task.
Changes proposed in this pull request:
max submissions/day > max number of submissions/month > Max total submissions