Modal scroll fix

[jayaike]

I made only the modal content scrollable while the buttons and the title remain fixed.

@pushkalkatara @vkartik97 PTAL

[codecov-io]

Codecov Report

Merging #273 into master will not change coverage.
The diff coverage is 29.72%.

@@           Coverage Diff           @@
##           master     #273   +/-   ##
=======================================
  Coverage   50.66%   50.66%           
=======================================
  Files          66       66           
  Lines        3766     3766           
  Branches      442      442           
=======================================
  Hits         1908     1908           
  Misses       1763     1763           
  Partials       95       95

Impacted Files	Coverage Δ
...bliclists/challengelist/challengelist.component.ts	47.57% <ø> (ø)	⬆️
...bmissions/challengeviewallsubmissions.component.ts	31.73% <100%> (ø)	⬆️
src/app/app.component.ts	35.21% <25%> (ø)	⬆️
...lengeleaderboard/challengeleaderboard.component.ts	34.07% <33.33%> (ø)	⬆️
src/app/services/endpoints.service.ts	64.89% <50%> (ø)	⬆️
...rc/app/components/challenge/challenge.component.ts	87.85% <7.69%> (ø)	⬆️
... and 1 more

Impacted Files	Coverage Δ
...bliclists/challengelist/challengelist.component.ts	47.57% <ø> (ø)	⬆️
...bmissions/challengeviewallsubmissions.component.ts	31.73% <100%> (ø)	⬆️
src/app/app.component.ts	35.21% <25%> (ø)	⬆️
...lengeleaderboard/challengeleaderboard.component.ts	34.07% <33.33%> (ø)	⬆️
src/app/services/endpoints.service.ts	64.89% <50%> (ø)	⬆️
...rc/app/components/challenge/challenge.component.ts	87.85% <7.69%> (ø)	⬆️
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6f58f3...920d7d6. Read the comment docs.

[krtkvrm]

Hi @nsjcorps
Can you please post the screenshot in which the changes are reflected

[jayaike]

How do I open the modal @vkartik97

[jayaike]

• Screenshot of fix

[jayaike]

You can judge by the position of the scroll bar

[Sanji515]

Hey @nsjcorps there's one more modal for editing the phase details, which is not using the utility/modal. Can you please check this?

[jayaike]

@Sanji515 no problem. Can you take a look at the other pr on code splitting

[jayaike]

Please take a look @vkartik97 @Sanji515

[Sanji515]

Thanks for the fix @nsjcorps , LGTM! This can be merged 🎉

[jayaike]

Thanks.

[jayaike]

Did you see the other PR? @Sanji515 #274

[Sanji515]

Did you see the other PR? @Sanji515

You mean this right? Not yet, looking to it now.

[jayaike]

Yes. That is correct. It's really just so you can see the significant difference if we lazy load @Sanji515

[lunayach]

Please move this style to .scss file.

[jayaike]

@lunayach I have updated the code.

[jayaike]

@Sanji515 I submitted my task btw :)

[lunayach]

Thanks, @nsjcorps.