Unit tests written for Improving the Coverage by Kajol-Kumari · Pull Request #295 · Cloud-CV/EvalAI-ngx

Kajol-Kumari · 2020-02-21T21:54:41Z

Feat: #85

Feature: Unit Tests for written for improving coverage for following files:

globalService
endpointService
challengeService
authService
apiService
challengelist-component
privacy-policy-component
contact-component
challenge-create-component
verify-email-component
signup-component
reset-password-component
reset-password-confirm-component
login-component
auth-component
host-analytics-component
analytics-component
about-component
app-component
teamlist-component

codecov-io · 2020-02-21T22:02:06Z

Codecov Report

Merging #295 into master will increase coverage by 14.58%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master     #295       +/-   ##
===========================================
+ Coverage   50.62%   65.20%   +14.58%     
===========================================
  Files          66       66               
  Lines        3771     3771               
  Branches      444      444               
===========================================
+ Hits         1909     2459      +550     
+ Misses       1767     1186      -581     
- Partials       95      126       +31

Impacted Files	Coverage Δ
src/app/services/endpoints.service.ts	`97.87% <100.00%> (+32.97%)`	⬆️
src/app/components/auth/auth.component.ts	`100.00% <0.00%> (+6.66%)`	⬆️
...lengelist/challengecard/challengecard.component.ts	`81.66% <0.00%> (+6.66%)`	⬆️
src/app/components/contact/contact.component.ts	`90.90% <0.00%> (+12.12%)`	⬆️
src/app/services/challenge.service.ts	`62.17% <0.00%> (+16.02%)`	⬆️
...ponents/privacy-policy/privacy-policy.component.ts	`86.11% <0.00%> (+16.66%)`	⬆️
src/app/services/api.service.ts	`90.47% <0.00%> (+22.22%)`	⬆️
src/app/services/global.service.ts	`67.38% <0.00%> (+29.18%)`	⬆️
src/app/components/auth/signup/signup.component.ts	`77.61% <0.00%> (+32.83%)`	⬆️
... and 9 more

Impacted Files	Coverage Δ
src/app/services/endpoints.service.ts	`97.87% <100.00%> (+32.97%)`	⬆️
src/app/components/auth/auth.component.ts	`100.00% <0.00%> (+6.66%)`	⬆️
...lengelist/challengecard/challengecard.component.ts	`81.66% <0.00%> (+6.66%)`	⬆️
src/app/components/contact/contact.component.ts	`90.90% <0.00%> (+12.12%)`	⬆️
src/app/services/challenge.service.ts	`62.17% <0.00%> (+16.02%)`	⬆️
...ponents/privacy-policy/privacy-policy.component.ts	`86.11% <0.00%> (+16.66%)`	⬆️
src/app/services/api.service.ts	`90.47% <0.00%> (+22.22%)`	⬆️
src/app/services/global.service.ts	`67.38% <0.00%> (+29.18%)`	⬆️
src/app/components/auth/signup/signup.component.ts	`77.61% <0.00%> (+32.83%)`	⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3d23ca...52e131f. Read the comment docs.

Kajol-Kumari · 2020-02-23T12:46:11Z

@Sanji515 SIr, Can you please take a look at the unit tests i have written. I am not sure whether i am doing it correctly or not as i am just a begineer in writing tests. If it's fine i'll continue writing tests for the other services and components and if not then i will work on improving the tests i have written till now.

Shekharrajak

From next time try to make small PRs - a specific code change , so that we can review it quickly. For now it is fine.

codecov-commenter · 2020-05-20T05:15:21Z

Codecov Report

Merging #295 into master will increase coverage by 14.30%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master     #295       +/-   ##
===========================================
+ Coverage   50.16%   64.47%   +14.30%     
===========================================
  Files          66       66               
  Lines        3873     3873               
  Branches      450      450               
===========================================
+ Hits         1943     2497      +554     
+ Misses       1836     1251      -585     
- Partials       94      125       +31

Impacted Files	Coverage Δ
src/app/services/endpoints.service.ts	`95.91% <100.00%> (+31.63%)`	⬆️
src/app/components/auth/auth.component.ts	`100.00% <0.00%> (+6.66%)`	⬆️
...lengelist/challengecard/challengecard.component.ts	`81.66% <0.00%> (+6.66%)`	⬆️
src/app/components/contact/contact.component.ts	`90.90% <0.00%> (+12.12%)`	⬆️
src/app/services/challenge.service.ts	`62.42% <0.00%> (+15.28%)`	⬆️
...ponents/privacy-policy/privacy-policy.component.ts	`86.11% <0.00%> (+16.66%)`	⬆️
src/app/services/api.service.ts	`90.47% <0.00%> (+22.22%)`	⬆️
src/app/services/global.service.ts	`66.95% <0.00%> (+28.75%)`	⬆️
src/app/components/auth/signup/signup.component.ts	`77.61% <0.00%> (+32.83%)`	⬆️
... and 9 more

Impacted Files	Coverage Δ
src/app/services/endpoints.service.ts	`95.91% <100.00%> (+31.63%)`	⬆️
src/app/components/auth/auth.component.ts	`100.00% <0.00%> (+6.66%)`	⬆️
...lengelist/challengecard/challengecard.component.ts	`81.66% <0.00%> (+6.66%)`	⬆️
src/app/components/contact/contact.component.ts	`90.90% <0.00%> (+12.12%)`	⬆️
src/app/services/challenge.service.ts	`62.42% <0.00%> (+15.28%)`	⬆️
...ponents/privacy-policy/privacy-policy.component.ts	`86.11% <0.00%> (+16.66%)`	⬆️
src/app/services/api.service.ts	`90.47% <0.00%> (+22.22%)`	⬆️
src/app/services/global.service.ts	`66.95% <0.00%> (+28.75%)`	⬆️
src/app/components/auth/signup/signup.component.ts	`77.61% <0.00%> (+32.83%)`	⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 932a9c0...28f265f. Read the comment docs.

lunayach · 2020-05-21T18:02:22Z

    expect(component).toBeTruthy();
  });
+
+  it('should call ngOninit', () => {


Is it possible to test more lines than the trivial component cases?

lunayach · 2020-05-21T18:05:57Z

+    expect(service.getUrl).toHaveBeenCalled();
+    expect(service3.teamCountAnalyticsURL).toHaveBeenCalled();
+  }));
+  it('should show download challenge participant team', inject([EndpointsService, ApiService],


Suggested change

it('should show download challenge participant team', inject([EndpointsService, ApiService],

it('should download challenge participant team', inject([EndpointsService, ApiService],

lunayach · 2020-05-21T18:20:09Z

+    expect(endpointsService.updateChallengePhaseDetailsURL(2, 3)).toBe('challenges/challenge/2/challenge_phase/3');
+  });
+  it('should return challenge phase split url' , () => {
+    expect(endpointsService.challengePhaseSplitURL(2)).toBe('challenges/2/challenge_phase_split');


Whenever possible, try not to hardcode URLs. Make them variables at the top and use them.

lunayach

Overall, great job @Kajol-Kumari! At some places, I felt more lines in the code could be tested and we might boost the test coverage a little more. Since this is not the top priority for now, you could add more tests a little later when you can.

Sanji515 · 2020-05-22T18:39:35Z

@Kajol-Kumari Can you please check why the build is failing here?

…improve_coverage_ngx

testing_the_tests_written

9d471fd

Kajol-Kumari added 7 commits February 22, 2020 12:46

added_some_more_tests

5baf0dd

added_some_more_tests

b2e0a92

unit_tests_for_endpoint_service_added

1ea9787

unit_tests_for_app_component_added

59b3ce8

unit_test_for_host-analytics_component_added

79edde2

added_challengelist_component_test

b640d52

component_unit_tests_Added

62a15a3

global_service_test_improved

caeee34

Kajol-Kumari marked this pull request as ready for review February 24, 2020 14:46

Kajol-Kumari added 7 commits February 24, 2020 23:00

challenge_service_test_added

c8f2a7e

challenge_service_test_build_fixed

58b1c52

tests_improved

21ea47a

removed extra files

dd8baf4

tests_improved

0aa324b

test_improved

2c5fd8d

test_for_challenge_create_component_added

4577b9a

Kajol-Kumari changed the title ~~Testing the unit tests written for Services~~ Unit tests written for Improving the Coverage Feb 28, 2020

Kajol-Kumari added 10 commits March 6, 2020 20:47

test_for_contact_component

bdc97b5

host_analytics_test_improved

f727c22

app_component_test_improved

774c7bf

app_component_test_improved

e8bb07b

app_component_test

af236af

privacy_policy_component_test_improved

b627c8e

privacy_policy_component_test_improved

2e70550

privacy_policy_component_test_improved

37fa8da

host_analytic_test_improved

844e4f7

challengelist_component_test_improved

1780746

Kajol-Kumari added 5 commits March 10, 2020 17:01

auth_omponent_test_improved

ff0dcf7

challengelist_component_test_improved

efa8d2b

signup_component_test_improved

2cdae8a

teamlist_component_test_added

52e131f

challenge_create_test_improved

316b492

Shekharrajak reviewed May 14, 2020

View reviewed changes

RishabhJain2018 requested review from Sanji515 and lunayach May 15, 2020 07:30

RishabhJain2018 approved these changes May 20, 2020

View reviewed changes

RishabhJain2018 added the can-be-merged label May 20, 2020

lunayach reviewed May 21, 2020

View reviewed changes

Comment thread src/app/components/auth/signup/signup.component.spec.ts Outdated

lunayach reviewed May 21, 2020

View reviewed changes

lunayach suggested changes May 21, 2020

View reviewed changes

fix_spacing_and_suggested_changes

d59fe7d

Kajol-Kumari force-pushed the improve_coverage_ngx branch from 2bf4cb0 to d59fe7d Compare May 21, 2020 19:26

RishabhJain2018 removed the can-be-merged label May 21, 2020

Merge branch 'master' of https://github.com/Cloud-CV/EvalAI-ngx into …

3dcb306

…improve_coverage_ngx

Kajol-Kumari force-pushed the improve_coverage_ngx branch from 68805ee to 3dcb306 Compare May 23, 2020 02:01

Merge branch 'master' of https://github.com/Cloud-CV/EvalAI-ngx into …

28f265f

…improve_coverage_ngx

Kajol-Kumari force-pushed the improve_coverage_ngx branch from 9d4a90a to 28f265f Compare May 31, 2020 04:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unit tests written for Improving the Coverage#295

Unit tests written for Improving the Coverage#295
Kajol-Kumari wants to merge 34 commits intoCloud-CV:masterfrom
Kajol-Kumari:improve_coverage_ngx

Kajol-Kumari commented Feb 21, 2020 •

edited

Loading

Uh oh!

codecov-io commented Feb 21, 2020 •

edited

Loading

Uh oh!

Kajol-Kumari commented Feb 23, 2020

Uh oh!

Shekharrajak left a comment

Uh oh!

codecov-commenter commented May 20, 2020 •

edited

Loading

Uh oh!

lunayach May 21, 2020

Uh oh!

lunayach May 21, 2020

Uh oh!

Uh oh!

lunayach May 21, 2020

Uh oh!

lunayach left a comment

Uh oh!

Sanji515 commented May 22, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

	it('should show download challenge participant team', inject([EndpointsService, ApiService],
	it('should download challenge participant team', inject([EndpointsService, ApiService],

Conversation

Kajol-Kumari commented Feb 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-io commented Feb 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Kajol-Kumari commented Feb 23, 2020

Uh oh!

Shekharrajak left a comment

Choose a reason for hiding this comment

Uh oh!

codecov-commenter commented May 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

lunayach May 21, 2020

Choose a reason for hiding this comment

Uh oh!

lunayach May 21, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lunayach May 21, 2020

Choose a reason for hiding this comment

Uh oh!

lunayach left a comment

Choose a reason for hiding this comment

Uh oh!

Sanji515 commented May 22, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Kajol-Kumari commented Feb 21, 2020 •

edited

Loading

codecov-io commented Feb 21, 2020 •

edited

Loading

codecov-commenter commented May 20, 2020 •

edited

Loading