Skip to content

API for challenge tags #2739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

pushkalkatara
Copy link
Contributor

@pushkalkatara pushkalkatara commented Apr 1, 2020

Fixes #2735

  • Add a tags field (postgres array field, default=[], null=True) to Challenges Model

  • List tags associated with a challenge on the challenge list page, challenge details page

  • Add tags support in Challenge creation templates so that tags automatically gets created when configuration is uploaded to EvalAI

  • Update/add unit tests for tags

Output:
Screenshot from 2020-04-01 22-02-10

Screenshot from 2020-04-01 22-05-07

@pushkalkatara
Copy link
Contributor Author

corresponding PR for frontend - Cloud-CV/EvalAI-ngx#313

@pushkalkatara
Copy link
Contributor Author

corresponding PR for challenge config - Cloud-CV/EvalAI-Starters#19

@pushkalkatara
Copy link
Contributor Author

Hi @RishabhJain2018 @deshraj

Please review the PR.

@RishabhJain2018 RishabhJain2018 self-requested a review June 21, 2020 17:03
@RishabhJain2018
Copy link
Member

Closing this since we already have this feature now!

Copy link

codecov bot commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.66%. Comparing base (96968d6) to head (8503b42).
Report is 1120 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2739      +/-   ##
==========================================
- Coverage   72.93%   72.66%   -0.27%     
==========================================
  Files          83       84       +1     
  Lines        5368     5425      +57     
==========================================
+ Hits         3915     3942      +27     
- Misses       1453     1483      +30     
Files with missing lines Coverage Δ
apps/challenges/models.py 99.48% <100.00%> (+0.02%) ⬆️
apps/challenges/serializers.py 95.96% <ø> (+0.13%) ⬆️
apps/challenges/urls.py 100.00% <ø> (ø)
apps/challenges/views.py 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

Files with missing lines Coverage Δ
apps/challenges/models.py 99.48% <100.00%> (+0.02%) ⬆️
apps/challenges/serializers.py 95.96% <ø> (+0.13%) ⬆️
apps/challenges/urls.py 100.00% <ø> (ø)
apps/challenges/views.py 100.00% <ø> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 235c0f0...8503b42. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 'tags' for each challenge
2 participants