Open
Conversation
Member
|
@sayamkanwar give me some time I'll go through the code. |
Ram81
requested changes
Dec 1, 2018
Member
Ram81
left a comment
Ram81
left a comment
There was a problem hiding this comment.
@sayamkanwar most of the changes in PR are style changes, can you revert the style changes and remove flake8 ignore
| @@ -1,9 +1,12 @@ | |||
| # flake8: noqa | |||
Member
There was a problem hiding this comment.
Please remove this and fix the style issues properly
| @@ -1,3 +1,4 @@ | |||
| # flake8: noqa | |||
| net[layerId]['shape']['input'] = None | ||
| net[layerId]['shape']['output'] = None | ||
| dataLayers = ['ImageData', 'Data', 'HDF5Data', 'Input', 'WindowData', 'MemoryData', 'DummyData'] | ||
| dataLayers = [ |
| if (net[layerId]['info']['type'] in dataLayers): | ||
|
|
||
| if net[layerId]['info']['type'] in dataLayers: | ||
|
|
| return JsonResponse({ | ||
| 'result': 'error', 'error': str(sys.exc_info()[1])}) | ||
| return JsonResponse({'result': 'error', | ||
| 'error': str(sys.exc_info()[1])}) |
| return JsonResponse({'result': 'error', 'error': str(sys.exc_info()[1])}) | ||
|
|
||
| if Network.objects.filter(name=net_name).exists(): | ||
|
|
| if Network.objects.filter(name=net_name).exists(): | ||
|
|
||
| # Update the exising json field | ||
|
|
Author
|
Sure @Ram81! |
Ram81
requested changes
Dec 10, 2018
Member
Ram81
left a comment
Ram81
left a comment
There was a problem hiding this comment.
@sayamkanwar also fix the webpack errors
Closed
Member
|
@sayamkanwar can you please fix the issues you mentioned in #496 |
Author
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I have implemented the dashboard's design and functionality.
Details: #471
Please review @Ram81 @RishabhJain2018
Thank you! :)