Skip to content

fixed minor grammatical and spelling mistakes#493

Open
llucifer97 wants to merge 10 commits intoCloud-CV:masterfrom
llucifer97:master
Open

fixed minor grammatical and spelling mistakes#493
llucifer97 wants to merge 10 commits intoCloud-CV:masterfrom
llucifer97:master

Conversation

@llucifer97
Copy link
Copy Markdown

IMPORTANT NOTES (please read and then delete):

  • The PR title should start with "Fix #bugnum: " (if applicable), followed by a clear one-line present-tense summary of the changes introduced in the PR. For example: "Fix #bugnum: Changed UI layout from horizontal to vertical.".

  • Please make sure to mention "#bugnum" somewhere in the description of the PR. This enables Github to link the PR to the corresponding bug.

Please also make sure to follow the contribution guidelines.

@llucifer97
Copy link
Copy Markdown
Author

@Ram81 Please review the PR.

Comment thread README.md
Comment thread README.md
* Under ``` Social Accounts ```, open ``` Social applications ``` and click on ``` Add Social Application ```.

* Choose the ``` Provider ``` of social application as ``` Github ``` and name it ``` Github ```.
* Choose the ``` Provider ``` of the social application as ``` Github ``` and name it ``` Github ```.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this

Comment thread README.md
* Under ```Social Accounts``` open ``` Social applications ```, click on ``` Add Social Application ```.

* Choose the ``` Provider ``` of social application as ``` Github ``` & name it ``` Github ```.
* Choose the ``` Provider ``` of the social application as ``` Github ``` & name it ``` Github ```.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this

Attached code requires [common dependencies](../../requirements/common.txt), plus `networkx` and `pydot` Python packages.
## Problem
Currently there's no tools for drawing Fabrik neural network diagram directly, without need to do it by hand. This research observes some ways to implement such function.
Currently, there are no tools for drawing Fabrik neural network diagram directly, without the need to do it by hand. This research observes some ways to implement such function.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rephrase this sentence

These methods share the common weakness: they cannot draw unsupported layers. For example, Keras cannot draw LRN layer. Also, they could be implemented in backend only.

Note that all tools can implemented with algorithms of conversion Fabrik net to framework model directly, without creating model files.
Note that all tools can implement with algorithms of conversion Fabrik net to framework model directly, without creating model files.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rephrase this too

If we dig inside Fabrik a little deeper, we find out that Fabrik stores neural network inside state as JS object. There are obtained sample net representation in `state_net.json`. It's Lenet MNIST with some layers deleted.

The only step to do is to draw graph based on this data. There are lots of ways, including [NN-SVG](https://github.com/zfrenchee/NN-SVG). Also a lot of different [JS libraries](https://stackoverflow.com/questions/7034/graph-visualization-library-in-javascript) and [other tools](https://www.quora.com/What-tools-are-good-for-drawing-neural-network-architecture-diagrams). In order to keep it simple, I created `draw_graph.py` that outputs pictured neural network with layer types and shapes. It uses [networkx](https://networkx.github.io/) for storing graph and pydot for visualisation, so it looks like Caffe's and Keras' network diagrams.
The only step to do is to draw a graph based on this data. There are lots of ways, including [NN-SVG](https://github.com/zfrenchee/NN-SVG). Also a lot of different [JS libraries](https://stackoverflow.com/questions/7034/graph-visualization-library-in-javascript) and [other tools](https://www.quora.com/What-tools-are-good-for-drawing-neural-network-architecture-diagrams). In order to keep it simple, I created `draw_graph.py` that outputs pictured neural network with layer types and shapes. It uses [networkx](https://networkx.github.io/) for storing graph and pydot for visualization, so it looks like Caffe's and Keras' network diagrams.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rephrase few lines in this

* ```changeHoveredLayer``` - changes which layer has the hover class on it, which outlines layer to emphasize a "hover"
* layerId
* ```modifyLayer``` - modifies layer, passed in layer is the new layer, and layer id is the id it needs to be replaced at.
* ```modifyLayer``` - modifies a layer, passed in the layer is the new layer, and layer id is the id it needs to be replaced at.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the that you added

* ```exportNet``` - AJAXs to backend and then passes back error/success
* framework
* ```importNet``` - AJAXs to backend and then passes back error/success
* ```importNet``` - AJAXs to the backend and then passes back error/success
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this

```toggleClass``` toggles classes for the dropdown on the sidebar for layer selection.
### ```paneElement.js```
```paneElement.js``` renders out each element of the pane, it is invoked by ```pane.js```
```paneElement.js``` render out each element of the pane, it is invoked by ```pane.js```
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this

Comment thread docs/source/adding_new_layers.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants