Punctuation processing bug fix and optimization#1
Open
dexter1691 wants to merge 1 commit intomasterfrom
Open
Conversation
Member
Author
|
If you want to check. Checkout this branch, and run this command |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This version finishes in ~ 23 seconds with no parallel jobs, while the original implementation takes approx 2 minutes.
There is a very slight change in accuracy but that's probably because the original implementation had tiny bugs which are also fixed
PTAL @prithv1 @deshraj
Ignore code-style. Just focus on the implementation.