fix: consolidate media and service worker fixes#26
Merged
Conversation
Tracking-only branch for the integration-trunk workflow. The code is already present on integration; this commit keeps the PR visible without stale dev ancestry.
54347eb to
c66111a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Consolidates the media cache, authenticated media rendering, URL preview, and service-worker session handling fixes from the local cleanup work.
Changeset: fix: harden authenticated media and service-worker transport.
This is one domain-sized split from the rebuilt aggregate branch in #25. The aggregate
integrationbranch atebd4679e8passed the full quality gate; this split is draft because it depends on shared cleanup from the companion split PRs.Pre-PR research: origin has related closed/merged media/service-worker PRs #8, #12, #13, #20, #21, #22, #23, and #24, plus aggregate #25.
SableClient/Sableandcinnyapp/cinnysearches for open media/service-worker overlap returned no open matches. Origin issues are disabled; searched upstream/cinny issues returned no matches to link.Fixes #
Type of change
Checklist:
Validation: rebuilt
integrationatebd4679e8passedpnpm lint,pnpm fmt:check,pnpm typecheck,pnpm test:run,pnpm knip, andpnpm build. Targeted media/settings/safe-area tests also passed before the aggregate push.AI disclosure:
AI-assisted consolidation and regression cleanup; maintainer should revise this disclosure before merge.