Skip to content

fix: stop sticky jump-to-present bottom repins#337

Merged
Just-Insane merged 1 commit into
integrationfrom
codex/bug-issue-328-jump-follow-sticky
Jun 23, 2026
Merged

fix: stop sticky jump-to-present bottom repins#337
Just-Insane merged 1 commit into
integrationfrom
codex/bug-issue-328-jump-follow-sticky

Conversation

@Just-Insane

Copy link
Copy Markdown
Collaborator

Description

Fixes #328

Keep the keyboard-close recovery from snapping readers back to live bottom after they have already scrolled away during the same keyboard session. The repin path now only fires when the session started at bottom and the timeline is still bottom-pinned at keyboard-dismiss time.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).
    The change tightens shouldRepinBottomAfterKeyboardClose so the keyboard-dismiss recovery only repins when the room both started the keyboard session at live bottom and is still at bottom when the viewport expands again. RoomTimeline now passes the current bottom state into that guard, which stops the close-animation path from dragging an off-bottom reader back to present after they intentionally scrolled upward. The keyboard-bottom recovery tests were updated to cover the new guard, and a patch changeset was added for the user-facing regression.

Validation

  • pnpm lint
  • pnpm fmt:check
  • pnpm typecheck
  • pnpm test:run
  • pnpm knip
  • pnpm build

@Just-Insane Just-Insane added the bug Something isn't working label Jun 23, 2026
@Just-Insane Just-Insane enabled auto-merge (squash) June 23, 2026 15:14
@github-actions

Copy link
Copy Markdown

Sentry Preview Error Triage

No Sentry errors found for this PR's preview deployment as of Tue, 23 Jun 2026 15:14:09 GMT.

This comment updates automatically after each push.

@github-actions

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

Status Preview URL Commit Alias Updated (UTC)
✅ Deployment successful! https://pr-337-charm.justin-tech.workers.dev d2b5595 pr-337 Tue, 23 Jun 2026 15:15:56 GMT

@github-code-quality

Copy link
Copy Markdown

Code Coverage Overview

Languages: JavaScript

JavaScript / code-coverage/vitest

The overall coverage remains at 27%, unchanged from the branch.


Code Coverage is in Public Preview. Learn more and provide us with your feedback.

@Just-Insane Just-Insane merged commit 5b46f5b into integration Jun 23, 2026
20 checks passed
@Just-Insane Just-Insane deleted the codex/bug-issue-328-jump-follow-sticky branch June 23, 2026 15:17

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ee886dfd24

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@@ -0,0 +1,5 @@
---
'charm-client': patch

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Point the changeset at the Charm package

This repo's release config defines a single package from package.json (name: "charm") via [package] in knope.toml, and the documented single-package changeset form is default: patch; there is no configured charm-client package. With this frontmatter the release tooling will not apply this entry to the app's version/changelog, so this fix can be omitted from the release notes or break release preparation. Please target default or charm instead.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Jump to Present/Follow Bottom is overly sticky

1 participant