Skip to content

fix: add pending send grace period#338

Merged
Just-Insane merged 3 commits into
integrationfrom
codex/bug-issue-332-pending-send-grace
Jun 23, 2026
Merged

fix: add pending send grace period#338
Just-Insane merged 3 commits into
integrationfrom
codex/bug-issue-332-pending-send-grace

Conversation

@Just-Insane

Copy link
Copy Markdown
Collaborator

Description

Add a short grace period before pending room messages are dimmed so normal sends do not look delayed immediately.

Closes #332

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).
    The AI-assisted portion adds a small pending-send timing helper plus unit coverage and wires Message.tsx to delay the dimmed pending style until a message has actually been stuck for about two seconds. Failed sends still use the existing failure styling immediately.

@Just-Insane Just-Insane added the bug Something isn't working label Jun 23, 2026
@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown

Sentry Preview Error Triage

No Sentry errors found for this PR's preview deployment as of Tue, 23 Jun 2026 16:36:20 GMT.

This comment updates automatically after each push.

@Just-Insane Just-Insane enabled auto-merge (squash) June 23, 2026 15:40
Comment thread src/app/features/room/message/pendingSendDisplay.ts
@github-code-quality

github-code-quality Bot commented Jun 23, 2026

Copy link
Copy Markdown

Code Coverage Overview

Languages: JavaScript

JavaScript / code-coverage/vitest

The overall coverage in the branch remains at 27%, unchanged from the branch.

Show a code coverage summary of the most impacted files.
File b54f2e6 5a44a74 +/-
src/app/feature...age/Message.tsx 3% 3% 0%
src/app/feature...gSendDisplay.ts 0% 100% +100%

Updated June 23, 2026 16:39 UTC
Code Coverage is in Public Preview. Learn more and provide us with your feedback.

Comment thread src/app/features/room/message/Message.tsx Outdated
@github-actions

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

Status Preview URL Commit Alias Updated (UTC)
✅ Deployment successful! https://pr-338-charm.justin-tech.workers.dev c4541c1 pr-338 Tue, 23 Jun 2026 16:38:18 GMT

@Just-Insane Just-Insane merged commit b5ed52d into integration Jun 23, 2026
18 checks passed
@Just-Insane Just-Insane deleted the codex/bug-issue-332-pending-send-grace branch June 23, 2026 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Grayed until sent is overly agressive

1 participant