fix: add jumbo emoji header spacing#340
Conversation
Sentry Preview Error TriageNo Sentry errors found for this PR's preview deployment as of Tue, 23 Jun 2026 17:08:40 GMT. This comment updates automatically after each push. |
Code Coverage OverviewLanguages: JavaScript JavaScript / code-coverage/vitestThe overall coverage in the branch remains at 27%, unchanged from the branch. Show a code coverage summary of the most impacted files.
Updated |
Deploying with
|
| Status | Preview URL | Commit | Alias | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! | https://pr-340-charm.justin-tech.workers.dev | 722e123 | pr-340 |
Tue, 23 Jun 2026 17:10:48 GMT |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f9aa079f9b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| extraSmall: { | ||
| fontSize: '1.25rem !important', | ||
| lineHeight: '1.4em', | ||
| marginTop: `var(${JumboEmojiHeaderSpacingVar}, 0)`, |
There was a problem hiding this comment.
Use the vanilla-extract variable directly
createVar values are already emitted as var(--...) references in this file (for example SpacingVar is used directly), so wrapping it again produces margin-top: var(var(--...), 0), which browsers ignore as invalid CSS. In every headerSpacing + jumbo emoji case the added top margin is therefore dropped and the header-overlap fix does not actually apply; use a defaulted variable or fallbackVar instead.
Useful? React with 👍 / 👎.
Description
Add a small top margin to jumbo emoji message bodies so oversized emoji do not touch the sender header above them. Also add a smoke fixture plus a Playwright assertion that measures the header-to-emoji gap.
Fixes #331
Type of change
Checklist:
AI disclosure:
This patch adds a small
marginTopto the jumbo emoji variants in the message text layout so the first oversized emoji line has breathing room from the sender metadata above it. It also extends the smoke page with a header-plus-jumbo-emoji fixture and updates the emoji polish Playwright smoke test to assert that the jumbo line stays separated from the header and still fits within its own line box.