fix: preserve composer padding in production#355
Merged
Just-Insane merged 1 commit intoJun 24, 2026
Conversation
Sentry Preview Error TriageNo Sentry errors found for this PR's preview deployment as of Wed, 24 Jun 2026 14:28:54 GMT. This comment updates automatically after each push. |
Deploying with
|
| Status | Preview URL | Commit | Alias | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! | https://pr-355-charm.justin-tech.workers.dev | 4d1bcde | pr-355 |
Wed, 24 Jun 2026 14:31:11 GMT |
Code Coverage OverviewLanguages: JavaScript JavaScript / code-coverage/vitestThe overall coverage remains at 27%, unchanged from the branch. Code Coverage is in Public Preview. Learn more and provide us with your feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Preserve the room composer padding in production by raising the editor padding rule specificity above the shared reset class, and add a smoke composer fixture that asserts the computed padding stays applied.
Fixes #351
Type of change
Checklist:
Validation:
pnpm test:e2e e2e/smoke/emoji-polish.spec.tspnpm fmt:checkpnpm typecheckpnpm test:runpnpm knippnpm buildpnpm lintis still blocked by pre-existing oxlint errors in untouched files such assrc/app/components/page/Page.tsxandsrc/app/components/message/layout/Base.tsxAI disclosure:
AI assistance helped trace the production cascade failure, update
Editor.css.tsso the composer padding survives the shared reset class, and extend the emoji smoke page/spec with a read-only composer fixture that checks the computed padding in Chromium.