fix: ignore extra runtime assets in hosted update checks#359
Conversation
Just-Insane
added
bug
Sentry Preview Error TriageNo Sentry errors found for this PR's preview deployment as of Thu, 25 Jun 2026 02:11:05 GMT. This comment updates automatically after each push. |
Code Coverage OverviewLanguages: JavaScript JavaScript / code-coverage/vitestThe overall coverage in the branch remains at 27%, unchanged from the branch. Show a code coverage summary of the most impacted files.
Updated |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 96fb924ade
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1d311e4ffb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Sentry Snapshot Testing
Snapshot diffs will appear when we have a base upload to compare against. Make sure to upload snapshots from your main branch. |
Deploying with
|
| Status | Preview URL | Commit | Alias | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! | https://pr-359-charm.justin-tech.workers.dev | bbabc95 | pr-359 |
Thu, 25 Jun 2026 02:12:46 GMT |
Sentry Snapshot Testing
No base snapshots found to compare against. Make sure snapshots are uploaded from your main branch. |
1 participant
Description
Ignore extra runtime-loaded assets when comparing the current page against the hosted app shell. The previous hosted-shell fallback treated any additional lazy-loaded CSS or JS still present in the DOM as proof that a newer shell existed, which could surface a false update banner even when the hosted
index.htmlalready matched the current shell assets.Related to #354
Related to #346
Type of change
Checklist:
AI disclosure:
This PR changes the hosted app-shell comparison in
appUpdates.tsto parse asset paths into sets and treat the hosted shell as current when all hosted shell assets are already present in the current page, even if extra runtime-loaded assets such as lazy-loaded CSS remain in the DOM. It adds a regression test that models an extra runtime stylesheet and verifies that the update check staysup-to-dateinstead of surfacing a false positive banner, while preserving the existing service worker and hosted-shell update flows.