fix: aggregate mobile back highlight badge#38
Merged
Just-Insane merged 1 commit intoJun 12, 2026
Conversation
Deploying with
|
| Status | Preview URL | Commit | Alias | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! | https://pr-38-sable.justin-tech.workers.dev | 0b87ec2 | pr-38 |
Fri, 12 Jun 2026 13:38:22 GMT |
There was a problem hiding this comment.
Pull request overview
Updates the room header’s mobile back-button highlight badge so it reflects aggregated highlight counts for the back target context (Home / Direct / Space) rather than only the currently open room, aligning the badge with the list the user will return to.
Changes:
- Aggregate highlight counts for the mobile back button based on the active route context (space vs direct vs home).
- Introduce room-list + unread aggregation hooks in
RoomViewHeaderto compute the badge value.
Comment on lines
+380
to
+382
| const directUnread = useRoomsUnread(directRooms, roomToUnreadAtom); | ||
| const homeUnread = useRoomsUnread(homeRooms, roomToUnreadAtom); | ||
| const spaceUnread = useRoomsUnread(spaceChildRooms, roomToUnreadAtom); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #
Type of change
Checklist:
AI disclosure: