Skip to content

Codex/fix mobile back highlight aggregate#41

Merged
Just-Insane merged 2 commits into
integrationfrom
codex/fix-mobile-back-highlight-aggregate
Jun 12, 2026
Merged

Codex/fix mobile back highlight aggregate#41
Just-Insane merged 2 commits into
integrationfrom
codex/fix-mobile-back-highlight-aggregate

Conversation

@Just-Insane

Copy link
Copy Markdown
Collaborator

Description

Fixes #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).

Copilot AI review requested due to automatic review settings June 12, 2026 15:01
@Just-Insane Just-Insane merged commit e29d730 into integration Jun 12, 2026
@github-actions

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

Status Preview URL Commit Alias Updated (UTC)
✅ Deployment successful! https://pr-41-sable.justin-tech.workers.dev a813576 pr-41 Fri, 12 Jun 2026 15:03:12 GMT

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the mobile Room view header’s back-button highlight badge logic so it reflects an aggregated highlight count across message rooms, rather than deriving the count via route/category-specific room lists.

Changes:

  • Replace route matching + per-scope unread aggregation with a single aggregation over selected “message rooms” (non-space rooms).
  • Remove now-unused router/path imports and room-list scope hooks used only for the previous back-target calculation.

@Just-Insane Just-Insane deleted the codex/fix-mobile-back-highlight-aggregate branch June 17, 2026 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants