simplify the package choice declaration - #834
Closed
chris1111 wants to merge 1 commit into
Closed
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The changes are small and localized to packaging scripts, with no confirmed functional regressions identified in the updated logic.
Pull request overview
This PR updates the Clover installer packaging scripts to simplify how the CloverLogoutHook package choice is declared/recorded during installation.
Changes:
- Hard-codes the CloverLogoutHook installer choice key in its
preinstalltemplate instead of using a substitution placeholder. - Simplifies the
addChoiceinvocation for the CloverLogoutHook package by removing explicit title/description arguments.
File summaries
| File | Description |
|---|---|
| CloverPackage/package/Scripts.templates/CloverLogoutHook/preinstall | Updates how the selected-choice key is recorded for the CloverLogoutHook install step. |
| CloverPackage/package/buildpkg.sh | Simplifies the CloverLogoutHook addChoice call formatting/arguments. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| CLOVER_INSTALLER_PLIST_NEW="${DEST_VOL}@CLOVER_INSTALLER_PLIST_NEW@" | ||
| install_log="${DEST_VOL}/Private/tmp/Clover_Install_Log.txt" | ||
| installer_choice="@INSTALLER_CHOICE@" | ||
| installer_choice="org.clover.cloverlogouthook" |
Contributor
Author
There was a problem hiding this comment.
So you have to correct all the po file because it will indicated on top of com.projectosx.clover.installer.plist @INSTALLER_CHOICE@ my commits is a temporary commmits while waiting for slice to adjust all the files po
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe in detail what was changed.
Type of change
Checklist
Additional information
Include any extra details relevant to your PR.