Apply foreach macro refactorings #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Pokorný <[email protected]>
This is a primitive that's easier to follow/more terse. Looking forward, we skip some places where we want to introduce a refactoring to drop an undesired non-transparent reliance on booth_conf global variable prior to modifying these two macros to that effect as well (respective places, at least, receive white-space-around-operators sanitization). Signed-off-by: Jan Pokorný <[email protected]>
This is to allow for better visual identification of the macro magic. Signed-off-by: Jan Pokorný <[email protected]>
jfriesse
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the first couple patches from #82. I'm hoping to continue slowly working my way through them over time. I'm also curious to see what tests get run on a pull request and if anything needs to be changed, so here's a simple one to play with.