Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[crmsh-4.6] Dev: Add error log when cluster services fail to start #1693

Open
wants to merge 2 commits into
base: crmsh-4.6
Choose a base branch
from

Conversation

liangxin1300
Copy link
Collaborator

backport #1692

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 66.85%. Comparing base (34cf2a4) to head (276c742).

Files with missing lines Patch % Lines
crmsh/bootstrap.py 50.00% 1 Missing ⚠️
crmsh/ui_cluster.py 91.66% 1 Missing ⚠️
Additional details and impacted files
Flag Coverage Δ
integration 52.72% <62.50%> (-0.01%) ⬇️
unit 49.39% <81.25%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
crmsh/service_manager.py 96.15% <100.00%> (+0.07%) ⬆️
crmsh/bootstrap.py 84.49% <50.00%> (-0.05%) ⬇️
crmsh/ui_cluster.py 75.14% <91.66%> (+0.28%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liangxin1300 liangxin1300 requested a review from zzhou1 February 23, 2025 13:23
@liangxin1300 liangxin1300 marked this pull request as ready for review February 23, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant