wip #3865
Open
wip #3865
+11
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clumens
requested changes
Apr 14, 2025
| @@ -470,8 +479,8 @@ do_pe_invoke_callback(xmlNode * msg, int call_id, int rc, xmlNode * output, void | |||
| crm_debug("Re-asking for the CIB: %d other peer updates still pending", | |||
| (num_cib_op_callbacks() - 1)); | |||
| sleep(1); | |||
There was a problem hiding this comment.
Remember to get rid of the sleep call - that's the whole point of moving the following code into a mainloop timer.
| controld_set_fsa_action_flags(A_PE_INVOKE); | ||
| controld_trigger_fsa(); | ||
| return G_SOURCE_CONTINUE; | ||
| } |
There was a problem hiding this comment.
Since this is just replacing the sleep and following code in do_pe_invoke_callback, I think this is supposed to be a one-off timer. That is, it should only execute one time and the way we do that is by returning G_SOURCE_REMOVE and passing FALSE to mainloop_timer_add.
| static void | ||
| do_pe_invoke_callback(xmlNode * msg, int call_id, int rc, xmlNode * output, void *user_data) | ||
| { | ||
| char *ref = NULL; | ||
| pid_t watchdog = pcmk__locate_sbd(); | ||
| static mainloop_timer_t *timer = NULL; |
There was a problem hiding this comment.
This variable shouldn't be static.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.