avoid some probably unnecessary watchdog-reboots with pacemaker_remot…#14
Open
wenningerk wants to merge 1 commit intoClusterLabs:mainfrom
Open
avoid some probably unnecessary watchdog-reboots with pacemaker_remot…#14wenningerk wants to merge 1 commit intoClusterLabs:mainfrom
wenningerk wants to merge 1 commit intoClusterLabs:mainfrom
Conversation
…e by using the knowledge of the cib most recently received before a connection-loss
| * on a remote-node without active resources | ||
| */ | ||
| if (current_cib) { | ||
| cib_copy = copy_xml(current_cib); |
Member
There was a problem hiding this comment.
Why make a copy if you're going to free the original at the end anyway?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e by using the knowledge of the cib most recently received before a connection-loss
This is related to and actually needs:
ClusterLabs/pacemaker#1130
I've observed a lot of cases where together with pacemaker-remote and using a watchdog
(without shared block-device) a lot of test-cases led to a watchdog-reboot on the remote-node.
But in cases where there are no active resources on the remote-node it would probably
not be needed to run into a suicide.
I put together a couple of testcases I've tried to drive to an at least improved outcome
seen from my pov:
without Cluster-Watcher:
Behaviour with Pacemaker-Watcher before change in sbd and pacemaker:
Behaviour with Pacemaker-Patch setting TCP_USER_TIMEOUT to 1/2 of SBD-Watchdog-Timeout:
Behaviour with Pacemaker-Patch + SBD-Patch checking remaining cib-info for running resources
on remote-node on cib-connection-lost: