-
Notifications
You must be signed in to change notification settings - Fork 1
Launch-quality output: snappier pacing, story-driven director, vocal-free music #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
00c0a41
Snappier launch-film camera pacing + story-driven example recipes + r…
Co-Messi 011f724
Replace bundled music with synthesized, provably vocal-free tracks
Co-Messi 5ef19f0
Generalize the AI director so generate produces launch-quality storie…
Co-Messi 00151d5
Address PR #11 review: destructive-filter safety, coerce, theme probe…
Co-Messi f94179c
Harden per adversarial review: destructive filter, LLM egress, coerci…
Co-Messi 68c31eb
Make the record-reproducibility timing check robust to CI scheduling …
Co-Messi 55e0693
Widen the reproducibility timing guard to a gross-divergence bound (4…
Co-Messi 5d75e4d
Close the two blocking review gaps: unprovable destructive keep, URL-…
Co-Messi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,30 @@ | ||
| # Bundled music — provenance & license | ||
|
|
||
| All four tracks are **original instrumental works produced for supercut**. | ||
| They were generated with MiniMax Music 2.5 from original style prompts written | ||
| for this project, then post-processed with ffmpeg (crossfade extension to | ||
| ~90–110s beds and loudness normalization to −16 LUFS). No pre-existing songs, | ||
| samples, or melodies were referenced or used as input. | ||
| All four tracks are **original instrumental works produced for supercut**, | ||
| synthesized from pure oscillators (sub bass, drum machine, filtered noise | ||
| hats, saw-wave pads, arpeggios) by `tools/synth-music.py` — there is no vocal | ||
| source, no sample, and no pre-existing song anywhere in the signal chain, so | ||
| the tracks cannot contain vocals. | ||
|
|
||
| **Reproducing the beds end-to-end.** `tools/synth-music.py` regenerates | ||
| equivalent beds (not necessarily bit-identical) from scratch. It needs: | ||
|
|
||
| * Python packages `numpy` and `scipy` — `pip install numpy scipy` | ||
| * `ffmpeg` on your PATH | ||
|
|
||
| Run `python3 tools/synth-music.py assets/music`. For each mood it synthesizes a | ||
| short WAV loop, then ffmpeg self-crossfades that loop to ~92s | ||
| (`acrossfade=d=1` ×3 → `atrim=0:92`), loudness-normalizes it | ||
| (`loudnorm=I=-15:TP=-1.5:LRA=9`), and encodes a 192 kbit/s 44.1 kHz stereo MP3 — | ||
| the exact pipeline that produced the checked-in beds. | ||
|
|
||
| To the extent the maintainers hold any rights in these recordings, they are | ||
| dedicated to the public domain under [CC0 1.0](https://creativecommons.org/publicdomain/zero/1.0/). | ||
| Use them in your videos — commercial or not — with no attribution required. | ||
|
|
||
| | track | vibe | length | bpm | | ||
| | -------------- | ---------------------------- | ------ | ---- | | ||
| | `pulse.mp3` | minimal tech, sleek | 100s | ~104 | | ||
| | `daybreak.mp3` | warm piano, optimistic | 93s | ~92 | | ||
| | `midnight.mp3` | cinematic ambient, premium | 110s | ~80 | | ||
| | `momentum.mp3` | driving electronic, punchy | 100s | ~122 | | ||
| | track | vibe | length | bpm | | ||
| | -------------- | ----------------------------- | ------ | ---- | | ||
| | `pulse.mp3` | minimal tech-house, sleek | 95s | ~104 | | ||
| | `daybreak.mp3` | bright melodic house, upbeat | 95s | ~110 | | ||
| | `midnight.mp3` | dark synthwave/techno, premium| 100s | ~100 | | ||
| | `momentum.mp3` | driving minimal techno | 95s | ~122 | |
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,30 +1,29 @@ | ||
| { | ||
| "version": 0, | ||
| "app_url": "http://127.0.0.1:4173", | ||
| "music_track": "institutional-01", | ||
| "music_track": "daybreak", | ||
| "scenes": [ | ||
| { | ||
| "name": "landing-cta", | ||
| "name": "the-pitch-and-signup", | ||
| "priority": 1, | ||
| "entry": { "url": "http://127.0.0.1:4173/", "prelude": [] }, | ||
| "depends_on": [], | ||
| "actions": [ | ||
| { "kind": "click", "selector": "#cta", "duration_ms": 1800 }, | ||
| { "kind": "type", "selector": "#email", "text": "ada@lumon.dev", "duration_ms": 2200 }, | ||
| { "kind": "click", "selector": "#join", "duration_ms": 1400 } | ||
| { "kind": "click", "selector": "#cta", "duration_ms": 1400 }, | ||
| { "kind": "type", "selector": "#email", "text": "ada@lumon.dev", "duration_ms": 1900 }, | ||
| { "kind": "click", "selector": "#join", "focus_selector": "#signup", "duration_ms": 1500 } | ||
| ], | ||
| "hold_ms": 800 | ||
| "hold_ms": 900 | ||
| }, | ||
| { | ||
| "name": "dashboard", | ||
| "name": "the-live-product", | ||
| "priority": 2, | ||
| "entry": { "url": "http://127.0.0.1:4173/dash", "prelude": [] }, | ||
| "entry": { "url": "http://127.0.0.1:4173/dash/", "prelude": [] }, | ||
| "depends_on": [], | ||
| "actions": [ | ||
| { "kind": "hover", "selector": "#task-ship", "duration_ms": 1600 }, | ||
| { "kind": "wait", "duration_ms": 1200 } | ||
| { "kind": "hover", "selector": "#task-ship", "focus_selector": "#tasks", "duration_ms": 1600 } | ||
| ], | ||
| "hold_ms": 600 | ||
| "hold_ms": 1000 | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| { | ||
| "version": 0, | ||
| "app_url": "http://127.0.0.1:4100", | ||
| "music_track": "midnight", | ||
| "scenes": [ | ||
| { | ||
| "name": "triage-the-fleet", | ||
| "priority": 1, | ||
| "entry": { "url": "http://127.0.0.1:4100/", "prelude": [] }, | ||
| "depends_on": [], | ||
| "actions": [ | ||
| { "kind": "click", "selector": "[data-testid=\"service-search\"]", "duration_ms": 900 }, | ||
| { "kind": "type", "selector": "[data-testid=\"service-search\"]", "text": "payments", "submit": true, "focus_selector": "[data-testid=\"metrics-panel\"]", "duration_ms": 1700 }, | ||
| { "kind": "click", "selector": ":nth-match([data-testid=\"service-item\"], 1)", "focus_selector": "[data-testid=\"kpi-row\"]", "duration_ms": 1500 }, | ||
| { "kind": "click", "selector": ":nth-match([data-testid=\"service-item\"], 3)", "focus_selector": "[data-testid=\"metrics-panel\"]", "duration_ms": 1500 } | ||
| ], | ||
| "hold_ms": 900 | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the model returns a different selector whose text merely begins with a valid one, for example an inventory containing
#ctaand a response of#cta2or#cta-secondary, thisstartsWithcheck rewrites it to#ctaand the whitelist accepts it. That bypasses the anti-hallucination retry path and can film/click the wrong element; the heal should only apply when the suffix is the known copied annotation boundary, not any arbitrary prefix.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 00151d5. coerceSelector only heals when the remainder after a valid-selector prefix is the display-annotation shape (whitespace + [tag]) or empty. #cta2 / #cta-secondary / #cta_alt have selector-continuation remainders → returned unchanged → correctly rejected. Regression test added.