Bump docs dependencies and drop dead ICA-AROMA requirements.txt - #502
Merged
Conversation
Clears 23 open Dependabot alerts, all of which were in non-runtime paths. docs/requirements.txt (21 alerts): jinja2 3.1.1 -> 3.1.6 pillow 10.1.0 -> 12.3.0 Pillow 12.x requires Python >= 3.10, so .readthedocs.yml moves from Python 3.9 to 3.10 (and ubuntu-20.04 to ubuntu-22.04, which provides it). Sphinx 5.0 supports 3.10, so the existing pin is unchanged. rabies/confound_correction_pkg/mod_ICA_AROMA/requirements.txt (2 alerts): Deleted. Nothing referenced it -- not setup.py, not rabies_environment.yml, not either Dockerfile. It was a leftover from the vendored upstream ICA-AROMA package and described a Python 2.7 install. Verified: sphinx-build -b html docs completes successfully on Python 3.10 with pillow 12.3.0 and jinja2 3.1.6 installed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011eAqGnoxyyiEzktoJEktZn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears all 23 open Dependabot alerts on this repo. None were on a runtime path — 21 were in the ReadTheDocs build environment and 2 were in a file nothing reads.
docs/requirements.txt— 21 alertsjinja2pillowPillow 12.x requires Python >= 3.10, so
.readthedocs.ymlmoves from Python 3.9 to 3.10, andubuntu-20.04toubuntu-22.04(the 20.04 image doesn't offer 3.10). Sphinx 5.0 still supports 3.10, so that pin is untouched.rabies/confound_correction_pkg/mod_ICA_AROMA/requirements.txt— 2 alertsDeleted. It pinned
numpy==1.14/pandas==0.23/matplotlib==2.2and nothing referenced it: notsetup.py, notrabies_environment.yml, not the top-levelDockerfile, notmod_ICA_AROMA/Dockerfile(which installs numpy/scipy viayum). It came in with the vendored upstream ICA-AROMA package and documented apython2.7 -m pip installworkflow.The only mention left is a line in the vendored
mod_ICA_AROMA/README.mddescribing that original Python 2.7 install. I left that README alone since it's upstream text, but it's now a dangling reference if you'd rather trim it.Verification
Built the docs in a clean Python 3.10 venv from the updated
docs/requirements.txt:Note — not addressed here
Dependabot doesn't parse conda environment files, so
rabies_environment.ymlis unscanned. It's what users and the container actually get, and it pinsscikit-learn=0.24.1,pandas=1.2.4,nibabel=3.2.1,matplotlib=3.3.4— all 2021. That's a compatibility exercise rather than a security patch, so it's deliberately out of scope for this PR, but it's the dependency surface that actually ships.🤖 Generated with Claude Code
https://claude.ai/code/session_011eAqGnoxyyiEzktoJEktZn