Skip to content

Sources priorities taken into account#11324

Open
rehsals wants to merge 6 commits into
CocoaPods:masterfrom
rehsals:bugfix/sources-priority-fix
Open

Sources priorities taken into account#11324
rehsals wants to merge 6 commits into
CocoaPods:masterfrom
rehsals:bugfix/sources-priority-fix

Conversation

@rehsals

@rehsals rehsals commented Apr 20, 2022

Copy link
Copy Markdown

See: #8679

@rehsals rehsals force-pushed the bugfix/sources-priority-fix branch from b17ac63 to 498cbf6 Compare April 20, 2022 12:40
@rehsals rehsals force-pushed the bugfix/sources-priority-fix branch from 498cbf6 to f2f4c8a Compare April 21, 2022 08:39
@rehsals rehsals marked this pull request as ready for review May 16, 2022 07:30
@dnkoutso dnkoutso added this to the 1.12.0 milestone Jun 23, 2022
@dnkoutso

Copy link
Copy Markdown
Contributor

Hi there can you add a CHANGELOG entry? thanks!

@rehsals

rehsals commented Jun 23, 2022

Copy link
Copy Markdown
Author

H! Sure, I'll add CHANGELOG entry

@rehsals

rehsals commented Jun 30, 2022

Copy link
Copy Markdown
Author

Hey @dnkoutso
I've added a CHANGELOG entry. But we also need this CocoaPods/Molinillo#166 to be merged.
Otherwise this fix won't be entirely correct.
How is it advisable to proceed here?

Comment thread CHANGELOG.md Outdated

##### Bug Fixes

* Sources priority in Podfile warks as stated in documentation.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: We've got a typo -- 'warks' should be 'works'.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Fixed

@dnkoutso dnkoutso modified the milestones: 1.12.0, 1.12.1 Feb 27, 2023
@dnkoutso dnkoutso modified the milestones: 1.12.1, 1.13.0 Apr 18, 2023
@dnkoutso dnkoutso modified the milestones: 1.13.0, 1.14.0 Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants