Skip to content

Web 68 create a new our team page and add tab in navigation #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

AbiT-246
Copy link
Collaborator

  • 'Our Team' page added
  • Internal and Technical team components added (temporarily commented out)
  • 'Page Under Construction' component added as a placeholder until contentful is set up

Copy link

vercel bot commented Mar 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
code-the-change-yyc-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2025 2:13am

Copy link
Collaborator

@burtonjong burtonjong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im unable to review the whole thing, so dont merge it yet
these are just my initial comments since im unable to run it locally im still in mexico lol

Copy link
Collaborator

@burtonjong burtonjong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the screen recording below, it would be nice to have the current tab selected either underlined or highlighted

also, you can use transitions to make the background (when hovered) fade instead of just appear/dissapear immediately. Reference this documentation: https://tailwindcss.com/docs/transition-property

You can do something similar for when their linkedins are hovered, please change the background color of the linkedin SVG by editing the FILL property. Thanks!

Screen.Recording.2025-05-06.202443.mp4

On mobile, the tabs stack as well.

image

@burtonjong
Copy link
Collaborator

WILL FIX THIS TMRW IM TOO TIRED @hannagracec @nataliey16

Copy link
Collaborator

@hannagracec hannagracec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@burtonjong burtonjong self-requested a review May 10, 2025 16:08
@burtonjong burtonjong merged commit 8eea90b into main May 10, 2025
3 checks passed
@hannagracec hannagracec deleted the WEB-68-Create-a-new-Our-Team-page-and-add-tab-in-Navigation branch May 15, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants