-
Notifications
You must be signed in to change notification settings - Fork 0
Web 68 create a new our team page and add tab in navigation #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web 68 create a new our team page and add tab in navigation #127
Conversation
AbiT-246
commented
Mar 23, 2025
- 'Our Team' page added
- Internal and Technical team components added (temporarily commented out)
- 'Page Under Construction' component added as a placeholder until contentful is set up
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…green lines to be above the header, but thats not working out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im unable to review the whole thing, so dont merge it yet
these are just my initial comments since im unable to run it locally im still in mexico lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the screen recording below, it would be nice to have the current tab selected either underlined or highlighted
also, you can use transitions to make the background (when hovered) fade instead of just appear/dissapear immediately. Reference this documentation: https://tailwindcss.com/docs/transition-property
You can do something similar for when their linkedins are hovered, please change the background color of the linkedin SVG by editing the FILL property. Thanks!
Screen.Recording.2025-05-06.202443.mp4
On mobile, the tabs stack as well.
WILL FIX THIS TMRW IM TOO TIRED @hannagracec @nataliey16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!!