Skip to content

Web 81 mobile view for alumni #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 63 commits into
base: main
Choose a base branch
from

Conversation

abia-jahangir
Copy link
Collaborator

Made alumni section fully responsive
Added slider to header (i.e. Presidents, Events, etc.)
Aesthetic changes:

  • coloured the pagination bullet on presidents carousel
  • made small changes to text size/weight

Copy link

vercel bot commented May 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
code-the-change-yyc-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 1, 2025 3:49am

Copy link
Collaborator

@burtonjong burtonjong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scrollbar is a little bit too thick, maybe reduce it by half
image

Alumni links are not centered on larger screens
image

Also, comparing the alumni links to the other links for the internal and external teams, they are different font sizes if we could make them the same that'd be nice

@hannagracec
Copy link
Collaborator

hannagracec commented Jun 1, 2025

Scrollbar is a little bit too thick, maybe reduce it by half image

Alumni links are not centered on larger screens image

Also, comparing the alumni links to the other links for the internal and external teams, they are different font sizes if we could make them the same that'd be nice

@burtonjong, I applied Abia's tab styling to the other sections to make them consistent and adjusted the scrollbar thickness. I also added a couple of other changes like font colour, the support of Omnes Bold (we didn't have that before for some reason), and a button at the top to scroll into the Alumni section. Lmk what you think!

@hannagracec hannagracec requested a review from burtonjong June 1, 2025 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants