Skip to content

Conversation

@fisayoadabs
Copy link
Contributor

@fisayoadabs fisayoadabs commented Feb 10, 2025

Got the image to be within the form and to display in the profile header. I would say we should transition to s3 bucket but I do not know how much storage we are allowed to have.
image

I also realized that this might also be part of 113 as well so you tell me if it is.

Copy link
Contributor

@burtonjong burtonjong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fisayoadabs
Copy link
Contributor Author

fisayoadabs commented Feb 24, 2025

@burtonjong Please Give Me s3 Bucket Access. Thank you 😊

@burtonjong
Copy link
Contributor

@burtonjong Please Give Me s3 Bucket Access. Thank you 😊

@fisayoadabs I gave you s3 access so you can test it - I also want to test it during the meeting tn if youll be joining so you can walk me through your code and what you did since this is a pretty big PR

Copy link
Contributor

@burtonjong burtonjong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple comments

next.config.js Outdated
domains: ["images.ctfassets.net"],
domains: [
"images.ctfassets.net",
"amplify-hackathonmanageme-profileimagestoragebucke-qigdi1utj018.s3.ca-central-1.amazonaws.com",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have to make this global, because this bucket is specific to you only

https://nextjs.org/docs/messages/next-image-unconfigured-host

you might have to upgrade next version to latest, which should be fine

@fisayoadabs fisayoadabs requested a review from burtonjong June 7, 2025 08:25
@burtonjong
Copy link
Contributor

I am assuming you went around testing stuff? upgrading 3 major packages (aws amplify, react and next) is a big upgrade and coudl cause problems

@burtonjong
Copy link
Contributor

burtonjong commented Jun 10, 2025

also, merge main into ur branch :)

wrong button as well oops

@burtonjong burtonjong closed this Jun 10, 2025
@burtonjong burtonjong reopened this Jun 10, 2025
@fisayoadabs fisayoadabs requested a review from burtonjong June 10, 2025 04:22
@burtonjong
Copy link
Contributor

burtonjong commented Jun 13, 2025

peer deps are messed up. once i test this branch (when i have time, idk when) I will take it over and fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants