Skip to content

feat: Dependency upgrades, javafx version bump, upgrade to jdk 24 #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 27, 2025

Conversation

CodeDead
Copy link
Owner

No description provided.

@CodeDead CodeDead added enhancement New feature or request dependencies Dependency upgrades labels Apr 27, 2025
@CodeDead CodeDead self-assigned this Apr 27, 2025
@CodeDead CodeDead requested a review from Copilot April 27, 2025 21:46
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the project's dependency on Java by bumping the JDK version from 23 to 24 in the GitHub workflow files.

  • Updated JDK version to 24 in the test workflow
  • Updated JDK version to 24 in the release workflow

Reviewed Changes

Copilot reviewed 4 out of 9 changed files in this pull request and generated no comments.

File Description
.github/workflows/test.yml Upgraded JDK from version 23 to 24 in test jobs
.github/workflows/release.yml Upgraded JDK from version 23 to 24 in release jobs (applied twice)
Files not reviewed (5)
  • gradle/gradle-daemon-jvm.properties: Language not supported
  • gradle/wrapper/gradle-wrapper.properties: Language not supported
  • gradlew: Language not supported
  • gradlew.bat: Language not supported
  • settings.gradle: Language not supported

@CodeDead CodeDead requested a review from Copilot April 27, 2025 23:20
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades various project dependencies, bumps the JavaFX version, and updates the JDK version from 23 to 24.

  • Removed the redundant "requires java.base" declaration from module-info.java
  • Updated the logger message in HelpUtils.java for added context
  • Removed the JDK 23 setup steps in GitHub workflows, implying an upgrade to JDK 24

Reviewed Changes

Copilot reviewed 6 out of 13 changed files in this pull request and generated no comments.

File Description
src/main/java/module-info.java Removed the explicit java.base requirement (redundant in modules)
src/main/java/com/codedead/opal/utils/HelpUtils.java Updated log message to provide additional details about file opening
.github/workflows/test.yml Removed JDK 23 setup steps; verify if a JDK 24 setup is needed
.github/workflows/release.yml Removed JDK 23 setup steps; verify if a JDK 24 setup is needed
Files not reviewed (7)
  • .AppImage/createAppImage.sh: Language not supported
  • gradle/gradle-daemon-jvm.properties: Language not supported
  • gradle/wrapper/gradle-wrapper.properties: Language not supported
  • gradlew: Language not supported
  • gradlew.bat: Language not supported
  • settings.gradle: Language not supported
  • src/main/resources/translations/OpalApplication_uk_UA.properties: Language not supported
Comments suppressed due to low confidence (3)

.github/workflows/test.yml:23

  • The PR title indicates an upgrade to JDK 24, but the workflow no longer sets up a JDK version. Consider adding a setup step for JDK 24 to ensure the tests run with the intended Java version.
-      - name: Setup JDK 23

.github/workflows/release.yml:23

  • The removal of the JDK 23 setup steps needs to be complemented with a step for JDK 24 as per the PR purpose. Update the release workflow accordingly to maintain consistency with the upgraded JDK version.
-      - name: Setup JDK 23

src/main/java/com/codedead/opal/utils/HelpUtils.java:39

  • [nitpick] Ensure that the updated log message 'from filesystem' accurately reflects the behavior of runnableFileOpener, as it may be misleading if files are sourced differently.
logger.info("Attempting to open file from filesystem {}", runnableFileOpener.getFileLocation());

@CodeDead CodeDead merged commit 01935be into development Apr 27, 2025
3 checks passed
@CodeDead CodeDead deleted the feature/upgrades branch April 27, 2025 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Dependency upgrades enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant