Pull real data for desk pages#34
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
kelvinkipruto
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/fact-checks/[desk]) to live Hasura data. The listing fetches that desk's fact-checks (route-scoped, reusing the existing server-side filter + pagination), and the hero gets its own carousel from a per-desk"<Desk Name> — Hero"content list.components/ui/HeroCarousel+HeroBanner; the home and desk heroes are now thin compositions (and drop"use client"). This also collapses the slide/dot key logic into one place.story.href+ index so duplicate placeholder images/titles can't collide (the warning previously persisted on the dots and on the static fallback); setdata-scroll-behavior="smooth"so Next doesn't smooth-scroll during route changes.Test plan
/fact-checks/climate-change): title + hero empty state render with no carousel; grid shows "No fact-checks have been published here yet." (desk routes are empty on staging).pnpm test(73 pass, incl. new route-clause cases),tsc, biome clean.Closes #33