Skip to content

Let $enableBranchNode be a Closure or null #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2025

Conversation

gp-lnuff
Copy link
Contributor

@gp-lnuff gp-lnuff commented Jun 7, 2025

Hello,

I've found myself using this package and needing the branch nodes to dynamically be selectable or not (namely, to be selectable when the selectTree is multiple choice, and not to be when it's not).
I thought it was quite odd that $enableBranchNode was type hinted to be strictly a bool, when the method getEnableBranchNode() already evaluates its value.

I changed it locally and it was working, so I though to make a pull request.
I would like to add tests, but they don't seem to be working out of the box, so if you could guide me on how to add them that would be most appreciated.

@CodeWithDennis
Copy link
Owner

Allowing a closure makes sense; however, I don't think making it nullable does...

@gp-lnuff
Copy link
Contributor Author

gp-lnuff commented Jun 9, 2025

I thought making it nullable would put it in line with most others "closure-able" properties in Filament components but after looking through Filament's source again I see that Closure|bool properties with a default bool value tend not to be nullable. I'll change that

@CodeWithDennis
Copy link
Owner

Thanks!

@CodeWithDennis CodeWithDennis merged commit 86a0762 into CodeWithDennis:3.x Jun 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants