This repository was archived by the owner on Oct 2, 2024. It is now read-only.
cowsay project part one #25
Merged
+114
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npm exploration - no CLI part - will put that later
40thieves
reviewed
Sep 26, 2021
There was a problem hiding this comment.
I really like this but... I've somewhat cannibalised the ideas for CodeYourFuture/syllabus#324. I'd be happy to switch my PR to another library if we can find a suitable one.
illicitonion
approved these changes
Oct 13, 2021
|
|
||
| ```js | ||
| "scripts": { | ||
| "cowsay": "cowsay Mooooo" |
There was a problem hiding this comment.
I'd be tempted to give this a different name, like "sayit", to emphasise that these things don't all need to be named the same - I see our trainees often assume things need to be named the same (or not understanding the differences) because we happen to do so in our examples...
Co-authored-by: Daniel Wagner-Hall <dawagner@gmail.com>
Co-authored-by: Daniel Wagner-Hall <dawagner@gmail.com>
Co-authored-by: Daniel Wagner-Hall <dawagner@gmail.com>
Co-authored-by: Daniel Wagner-Hall <dawagner@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handling all the feedback from CodeYourFuture/syllabus#189
this is an npm exploration, which is now suitable as they npm Jest from JS-1
this project has no CLI part -have put that in JS3!
View rendered challenge-cowsay-one/readme.md