This repository was archived by the owner on Jan 14, 2024. It is now read-only.
Glasgow Class 6 - Rahma Berhan - JavaScript_1 - Week_4 #231
+130
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annacollins85
approved these changes
Apr 5, 2023
There was a problem hiding this comment.
Great work! Your code is well formatted and you have used good variable names throughout which makes it very easy to read and follow. This is really important for other developers to be able to work with your code. Well done! Just added a few comments for improvement but there weren't many! 👏
Comment on lines
+9
to
+12
| return names.find(function (name) { | ||
| if (name.startsWith("A") && name.length > 7) return name; | ||
| }); | ||
| } |
| @@ -16,6 +16,10 @@ let students = ["Islam", "Lesley", "Harun", "Rukmini"]; | |||
| let mentors = ["Daniel", "Irina", "Mozafar", "Luke"]; | |||
|
|
|||
| let pairs = pairsByIndex.map(function (indexes) { | |||
| if (pairsByIndex.some((element) => element === null)) { | |||
| @@ -5,7 +5,7 @@ | |||
| let students = ["Omar", "Austine", "Dany", "Swathi", "Lesley", "Rukmini"]; | |||
| let group = ["Austine", "Dany", "Swathi", "Daniel"]; | |||
|
|
|||
| let groupIsOnlyStudents; // complete this statement | |||
| let groupIsOnlyStudents = group.every((i) => students.includes(i)); | |||
There was a problem hiding this comment.
This is good but I would use a more descriptive name, e.g.
Suggested change
| let groupIsOnlyStudents = group.every((i) => students.includes(i)); | |
| let groupIsOnlyStudents = group.every((name) => students.includes(name)); |
Comment on lines
+11
to
+13
| let pairsByIndex = pairsByIndexRaw.filter( | ||
| (element) => Array.isArray(element) && element.length === 2 | ||
| ); |
| let firstFive; // complete this statement | ||
| let lastFive; // complete this statement | ||
| let firstFive = everyone.slice(0, 5); // complete this statement | ||
| let lastFive = everyone.slice(everyone.length - 5, everyone.length); // complete this statement |
There was a problem hiding this comment.
There's an easier way of doing this
Suggested change
| let lastFive = everyone.slice(everyone.length - 5, everyone.length); // complete this statement | |
| let lastFive = everyone.slice(-5) |
| @@ -44,7 +51,16 @@ Write a function that: | |||
| - Numbers greater 100 must be replaced with 100. | |||
| */ | |||
|
|
|||
| function formatPercentage() { | |||
| function formatPercentage(numbers) { | |||
| numbersWithPercentages = numbers.map(addPercentage); | |||
| //ERROR --->>>> indSafeOxygenLevel function returns undefined if no valid planets found | ||
|
|
||
| function findSafeOxygenLevel(array) { | ||
| if (array.some((number) => number.includes("%"))) { |
There was a problem hiding this comment.
Why do we need this check here? Will it not always be the case?
Comment on lines
+26
to
+33
| function checkLevel(number) { | ||
| if (number > 19.5 && number < 23.5) { | ||
| return true; | ||
| } else { | ||
| return false; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
You could make this simpler by:
Suggested change
| function checkLevel(number) { | |
| if (number > 19.5 && number < 23.5) { | |
| return true; | |
| } else { | |
| return false; | |
| } | |
| } | |
| } | |
| function checkLevel(number) { | |
| return (number > 19.5 && number < 23.5); | |
| } |
| return families.filter(familyNameChecker); | ||
| } | ||
|
|
||
| function familyNameChecker(familyName) { |
There was a problem hiding this comment.
You could have used array.split(' ') to create an array and then check the last item in the array is "family" and check the first one begins with "A" but is not just "A"
Comment on lines
+10
to
+19
| function getEligibleStudents(attendanceData) { | ||
| let studentsNameWith8Classes = []; | ||
| attendanceData.forEach((student) => { | ||
| if (student[1] >= 8) { | ||
| studentsNameWith8Classes.push(student[0]); | ||
| return true; | ||
| } | ||
| }); | ||
| return studentsNameWith8Classes; | ||
| } |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.