Skip to content

cowsay CLI project with scaffolding #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2021

Conversation

SallyMcGrath
Copy link
Member

@SallyMcGrath SallyMcGrath commented Aug 4, 2021

Regarding Cowsay - I split this into two projects and put one ins JS1 and another in JS3. I made the suggested changes on CodeYourFuture/syllabus#189 including some commented in scaffolding in the solutions.


View rendered challenge-cowsay-two/readme.md

Copy link
Member

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


### Iterating

We could make our program more accessible by adding a command line interface that prompts us to write in the cow's words. What tools can we use? I think we could use:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you trying to nudge them towards removing the argument, or prompting if no argument was given? I feel like being slightly more explicit about that could be useful (this doesn't feel like super useful ambiguity to have them resolve :))

@SallyMcGrath SallyMcGrath removed the request for review from 40thieves October 13, 2021 20:08
@SallyMcGrath SallyMcGrath merged commit 2aa2010 into CodeYourFuture:master Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants