Skip to content

London | 25-ITP-Sep |Sophia Mohamed | Sprint 2 | book library project #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saff-coder wants to merge 4 commits into
base: main
Choose a base branch
from
Open

London | 25-ITP-Sep |Sophia Mohamed | Sprint 2 | book library project #342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c5b9eab
I have Fixed the index and the Submit button
saff-coder Dec 5, 2025
73971be
encoding was corrected
saff-coder Dec 6, 2025
d3bdc53
removed unnecessary functions
saff-coder Dec 6, 2025
12d400d
Improve book form validation and table rendering
saff-coder Dec 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
93 changes: 48 additions & 45 deletions debugging/book-library/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
<!DOCTYPE html>
<html>
<html lang="en">
<head>
<title> </title>
<meta charset="utf-8" />
<title>My book library</title>
<meta
charset="utf-8"
name="viewport"
name="viewport"
content="width=device-width, initial-scale=1.0"
/>
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
Expand All @@ -28,47 +28,50 @@ <h1>Library</h1>
</button>

<div id="demo" class="collapse">
<div class="form-group">
<label for="title">Title:</label>
<input
type="title"
class="form-control"
id="title"
name="title"
required
/>
<label for="author">Author: </label>
<input
type="author"
class="form-control"
id="author"
name="author"
required
/>
<label for="pages">Pages:</label>
<input
type="number"
class="form-control"
id="pages"
name="pages"
required
/>
<label class="form-check-label">
<input
type="checkbox"
class="form-check-input"
id="check"
value=""
/>Read
</label>
<form id="bookForm">
<div class="form-group">
<label for="title">Title:</label>
<input
type="text"
class="form-control"
id="title"
name="title"
required
/>

<label for="author">Author: </label>
<input
type="text"
class="form-control"
id="author"
name="author"
required
/>

<label for="pages">Pages:</label>
<input
type="number"
class="form-control"
id="pages"
name="pages"
required
/>

<label class="form-check-label">
<input
type="submit"
value="Submit"
class="btn btn-primary"
onclick="submit();"
/>
</div>
type="checkbox"
class="form-check-input"
id="check"
/>Read
</label>

<button type="submit" class="btn btn-primary">
Submit
</button>
</div>
</form>
</div>


<table class="table" id="display">
<thead class="thead-dark">
Expand All @@ -91,6 +94,6 @@ <h1>Library</h1>
</tbody>
</table>

<script src="script.js"></script>
<script src="script.js" type="module"></script>
</body>
</html>
</html>
170 changes: 96 additions & 74 deletions debugging/book-library/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,103 +1,125 @@
let myLibrary = [];
const myLibrary = [];

window.addEventListener("load", function (e) {
// When page loads, add starter books and render
window.addEventListener("load", function () {
populateStorage();
render();
});

function populateStorage() {
if (myLibrary.length == 0) {
let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
let book2 = new Book(
if (myLibrary.length === 0) {
const book1 = new Book("Robinson Crusoe", "Daniel Defoe", 252, true);
const book2 = new Book(
"The Old Man and the Sea",
"Ernest Hemingway",
"127",
127,
true
);
myLibrary.push(book1);
myLibrary.push(book2);
render();
myLibrary.push(book1, book2);
}
}

const title = document.getElementById("title");
const author = document.getElementById("author");
const pages = document.getElementById("pages");
const check = document.getElementById("check");

//check the right input from forms and if its ok -> add the new book (object in array)
//via Book function and start render function
function submit() {
if (
title.value == null ||
title.value == "" ||
pages.value == null ||
pages.value == ""
) {
alert("Please fill all fields!");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
render();
// === DOM elements ===
const bookFormEl = document.getElementById("bookForm");
const titleInputEl = document.getElementById("title"); // .value is a string
const authorInputEl = document.getElementById("author"); // .value is a string
const pagesInputEl = document.getElementById("pages"); // .value is a string
const isReadCheckboxEl = document.getElementById("check"); // .checked is boolean

// Check the form and, if OK, add a new book and re-render
bookFormEl.addEventListener("submit", handleBookFormSubmit);

function handleBookFormSubmit(event) {
event.preventDefault(); // stop page reload

// 🔹 Normalise / preprocess input
const title = titleInputEl.value.trim();
const author = authorInputEl.value.trim();
const pages = Number(pagesInputEl.value);
const isRead = isReadCheckboxEl.checked;

// 🔹 Validation
if (!title || !author) {
alert("Title and author are required.");
return;
}

if (!Number.isFinite(pages) || pages <= 0) {
Copy link
Contributor

@cjyuan cjyuan Dec 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also reject non-integers.

alert("Pages must be a positive number.");
return;
}

// 🔹 Create and store the new book
const newBook = new Book(title, author, pages, isRead);
myLibrary.push(newBook);

render();
bookFormEl.reset();
}

// Book constructor
function Book(title, author, pages, check) {
this.title = title;
this.author = author;
this.pages = pages;
this.check = check;
this.check = check; // true = read, false = not read
}

function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
table.deleteRow(n);
}
//insert updated row and cells
let length = myLibrary.length;
for (let i = 0; i < length; i++) {
let row = table.insertRow(1);
let titleCell = row.insertCell(0);
let authorCell = row.insertCell(1);
let pagesCell = row.insertCell(2);
let wasReadCell = row.insertCell(3);
let deleteCell = row.insertCell(4);
titleCell.innerHTML = myLibrary[i].title;
authorCell.innerHTML = myLibrary[i].author;
pagesCell.innerHTML = myLibrary[i].pages;

//add and wait for action for read/unread button
let changeBut = document.createElement("button");
changeBut.id = i;
changeBut.className = "btn btn-success";
wasReadCell.appendChild(changeBut);
let readStatus = "";
if (myLibrary[i].check == false) {
readStatus = "Yes";
} else {
readStatus = "No";
}
changeBut.innerText = readStatus;

changeBut.addEventListener("click", function () {
myLibrary[i].check = !myLibrary[i].check;
const table = document.getElementById("display");
const tbody = table.querySelector("tbody");

// 🔹 Clear previous rows in one go (keep header)
tbody.innerHTML = "";

// insert updated rows and cells
myLibrary.forEach((book, index) => {
const row = document.createElement("tr");

const titleCell = document.createElement("td");
const authorCell = document.createElement("td");
const pagesCell = document.createElement("td");
const wasReadCell = document.createElement("td");
const deleteCell = document.createElement("td");

// 🔹 Use textContent (safe & fast)
titleCell.textContent = book.title;
authorCell.textContent = book.author;
pagesCell.textContent = book.pages;

// Read/unread button
const readBtn = document.createElement("button");
readBtn.type = "button";
readBtn.className = "btn btn-success btn-sm";
readBtn.textContent = book.check ? "Yes" : "No";
readBtn.addEventListener("click", () => {
myLibrary[index].check = !myLibrary[index].check;
render();
});
wasReadCell.appendChild(readBtn);

// Delete button
const deleteBtn = document.createElement("button");
deleteBtn.type = "button";
deleteBtn.className = "btn btn-warning btn-sm";
deleteBtn.textContent = "Delete";

//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
myLibrary.splice(i, 1);
deleteBtn.addEventListener("click", () => {
const confirmed = confirm(`Delete "${book.title}"?`);
if (!confirmed) return;

myLibrary.splice(index, 1);
render();
});
}

deleteCell.appendChild(deleteBtn);

row.appendChild(titleCell);
row.appendChild(authorCell);
row.appendChild(pagesCell);
row.appendChild(wasReadCell);
row.appendChild(deleteCell);

tbody.appendChild(row);
});
}