Skip to content

Glasgow | 25-ITP-Sep |Mohammed Abdoon| Sprint 2 | book library #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
M-Abdoon wants to merge 3 commits into
base: main
Choose a base branch
from
+70 −75
Open

Glasgow | 25-ITP-Sep |Mohammed Abdoon| Sprint 2 | book library #343

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7af1a09
finished library book
M-Abdoon Dec 6, 2025
0201147
removed debugging code
M-Abdoon Dec 7, 2025
6e8d20a
improved the code
M-Abdoon Dec 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 16 additions & 22 deletions debugging/book-library/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
<!DOCTYPE html>
<html>
<html lang="en">
<head>
<title> </title>
<title>My Book Library</title>

<meta
charset="utf-8"
name="viewport"
content="width=device-width, initial-scale=1.0"
/>
>
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script>
<link
rel="stylesheet"
href="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css"
/>
<link rel="stylesheet" type="text/css" href="style.css" />
>
<link rel="stylesheet" type="text/css" href="style.css" >
</head>

<body>
Expand All @@ -31,42 +31,42 @@ <h1>Library</h1>
<div class="form-group">
<label for="title">Title:</label>
<input
type="title"
type="text"
class="form-control"
id="title"
name="title"
required
/>
>
<label for="author">Author: </label>
<input
type="author"
type="text"
class="form-control"
id="author"
name="author"
required
/>
>
<label for="pages">Pages:</label>
<input
type="number"
class="form-control"
id="pages"
name="pages"
required
/>
>
<label class="form-check-label">
<input
type="checkbox"
class="form-check-input"
id="check"
value=""
/>Read
>Read
</label>
<input
type="submit"
value="Submit"
class="btn btn-primary"
onclick="submit();"
/>
id = "submitBtn"
>
</div>
</div>

Expand All @@ -80,14 +80,8 @@ <h1>Library</h1>
<th></th>
</tr>
</thead>
<tbody>
<tr>
<td></td>
<td></td>
<td></td>
<td></td>
<td></td>
</tr>
<tbody id="tableBody">

</tbody>
</table>

Expand Down
101 changes: 54 additions & 47 deletions debugging/book-library/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,46 +2,53 @@ let myLibrary = [];

window.addEventListener("load", function (e) {
populateStorage();
render();
});

function populateStorage() {
if (myLibrary.length == 0) {
let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
let book1 = new Book("Robison Crusoe", "Daniel Defoe", 252, true);
let book2 = new Book(
"The Old Man and the Sea",
"Ernest Hemingway",
"127",
127,
true
);
myLibrary.push(book1);
myLibrary.push(book2);
render();
}
}

const title = document.getElementById("title");
const author = document.getElementById("author");
const pages = document.getElementById("pages");
const check = document.getElementById("check");
const submitBtn = document.getElementById("submitBtn");
submitBtn.addEventListener("click", () => {
submit();
})

//check the right input from forms and if its ok -> add the new book (object in array)
//via Book function and start render function
function submit() {
if (
title.value == null ||
title.value == "" ||
pages.value == null ||
pages.value == ""
) {
function submit() {
let titleInput = document.getElementById("title").value;
let authorInput = document.getElementById("author").value.trim();
const pagesInput = Number(document.getElementById("pages").value.trim());
const checkBtn = document.getElementById("check");
Copy link
Contributor

@cjyuan cjyuan Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Title may also contain leading/trailing space.
  • The first three variables are assigned the input values (and not DOM elements). Why not do the same to the 4th variable?
  • Note: Number() ignores leading/trailing space in a string, so trim() is optional on line 31.

Copy link
Author

@M-Abdoon M-Abdoon Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the first three variables store the current input values because we need them directly, while the checkBtn is only needed to attach a click event to it, not it's value. so that's why I handled it differently.


titleInput = titleInput.replace(/</g, "");
authorInput = authorInput.replace(/</g, "");
Comment on lines +34 to +35
Copy link
Contributor

@cjyuan cjyuan Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if a book title really contains a "<" character?
Why only remove '<' and not all "special characters" that may be misinterpreted as part of HTML code?

Copy link
Author

@M-Abdoon M-Abdoon Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought only '<' could be misinterpreted as part of HTML.
I removed the validation completely and used .textContent instead of .innerHTML when assigning the input to the new object, so the page is not affected when displaying the text.


console.log(titleInput);
if ( titleInput == "" || authorInput == "" || pagesInput == "" ) {
Copy link
Contributor

@cjyuan cjyuan Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why compare pagesInput to ""?

Copy link
Author

@M-Abdoon M-Abdoon Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make sure whether the input isn't empty or not.

Copy link
Contributor

@cjyuan cjyuan Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pagesInput is a number.

alert("Please fill all fields!");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
render();
}
}

if (!Number.isInteger(pagesInput) || pagesInput <= 0) {
alert("Pages must be a valid number");
return false;
}

let book = new Book(titleInput, authorInput, pagesInput, checkBtn.checked);
myLibrary.push(book);
render();
}

function Book(title, author, pages, check) {
this.title = title;
Expand All @@ -51,52 +58,52 @@ function Book(title, author, pages, check) {
}

function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
let tableBody = document.getElementById("tableBody");

//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
table.deleteRow(n);
}
tableBody.innerHTML = "";

//insert updated row and cells
let length = myLibrary.length;
for (let i = 0; i < length; i++) {
let row = table.insertRow(1);
let titleCell = row.insertCell(0);
let authorCell = row.insertCell(1);
let pagesCell = row.insertCell(2);
let row = tableBody.insertRow(0);
let titleCell = row.insertCell(0);
let authorCell = row.insertCell(1);
let pagesCell = row.insertCell(2);
let wasReadCell = row.insertCell(3);
let deleteCell = row.insertCell(4);
titleCell.innerHTML = myLibrary[i].title;
let deleteCell = row.insertCell(4);
titleCell.innerHTML = myLibrary[i].title;
authorCell.innerHTML = myLibrary[i].author;
Copy link
Contributor

@cjyuan cjyuan Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By assigning a value to .innerHTML, some "special characters" in the book title may be misinterpreted as part of HTML code.

Copy link
Author

@M-Abdoon M-Abdoon Dec 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I used .textContent instead so we ignore any special characters.

pagesCell.innerHTML = myLibrary[i].pages;
pagesCell.innerHTML = myLibrary[i].pages;

//add and wait for action for read/unread button
let changeBut = document.createElement("button");
changeBut.id = i;
changeBut.className = "btn btn-success";
wasReadCell.appendChild(changeBut);
let changeButton = document.createElement("button");
changeButton.className = "btn btn-success";
wasReadCell.appendChild(changeButton);
let readStatus = "";
if (myLibrary[i].check == false) {
if (myLibrary[i].check == true) {
readStatus = "Yes";
} else {
readStatus = "No";
}
changeBut.innerText = readStatus;
changeButton.innerText = readStatus;
Copy link
Contributor

@cjyuan cjyuan Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is possible to simplify the code on lines 83-89 into one or two lines of code. As a challenge, can you simplify it?


changeBut.addEventListener("click", function () {
changeButton.addEventListener("click", function () {
myLibrary[i].check = !myLibrary[i].check;
render();
});

//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
myLibrary.splice(i, 1);
let deleteButtton = document.createElement("button");
deleteButtton.id = i
deleteCell.appendChild(deleteButtton);
deleteButtton.className = "btn btn-warning";
deleteButtton.innerHTML = "Delete";
deleteButtton.addEventListener("click", function () {
const currentBookTitle = myLibrary[i].title;
if (myLibrary.splice(i, 1)) {
alert(`You've deleted title: ${currentBookTitle}`);
}
render();
});
}
Expand Down