Skip to content

Glasgow | 25-ITP-SEP | Alaa Tagi | Sprint 2 | Book/Library #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alaa-Tagi wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Glasgow | 25-ITP-SEP | Alaa Tagi | Sprint 2 | Book/Library #346

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6cf78cb
made some changes in script.js file to meet the rquirements
Alaa-Tagi Dec 7, 2025
829111c
edit HTML,JS and CSS files to correct validation errors
Alaa-Tagi Dec 8, 2025
d7df43f
changes some lines to validate pages correctly, grouped cell creation…
Alaa-Tagi Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
94 changes: 32 additions & 62 deletions debugging/book-library/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,15 @@
<!DOCTYPE html>
<html>
<html lang="en">
<head>
<title> </title>
<meta
charset="utf-8"
name="viewport"
content="width=device-width, initial-scale=1.0"
/>
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>My Book Library</title>
<link
rel="stylesheet"
href="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css"
/>
<link rel="stylesheet" type="text/css" href="style.css" />

<link rel="stylesheet" href="style.css" />
</head>

<body>
Expand All @@ -23,50 +18,31 @@ <h1>Library</h1>
<p>Add books to your virtual library</p>
</div>

<button data-toggle="collapse" data-target="#demo" class="btn btn-info">
Add new book
<button
data-toggle="collapse"
data-target="#addBookForm"
class="btn btn-info"
>
Add Book
</button>

<div id="demo" class="collapse">
<div class="form-group">
<div id="addBookForm" class="collapse">
<div class="form-group p-3">
<label for="title">Title:</label>
<input
type="title"
class="form-control"
id="title"
name="title"
required
/>
<label for="author">Author: </label>
<input
type="author"
class="form-control"
id="author"
name="author"
required
/>
<input type="text" class="form-control" id="title" required />

<label for="author">Author:</label>
<input type="text" class="form-control" id="author" required />

<label for="pages">Pages:</label>
<input
type="number"
class="form-control"
id="pages"
name="pages"
required
/>
<label class="form-check-label">
<input
type="checkbox"
class="form-check-input"
id="check"
value=""
/>Read
</label>
<input
type="submit"
value="Submit"
class="btn btn-primary"
onclick="submit();"
/>
<input type="number" class="form-control" id="pages" min="1" required />

<div class="form-check mt-2">
<input type="checkbox" class="form-check-input" id="check" />
<label class="form-check-label" for="check">Read</label>
</div>

<button class="btn btn-primary mt-3" onclick="submit()">Submit</button>
</div>
</div>

Expand All @@ -75,21 +51,15 @@ <h1>Library</h1>
<tr>
<th>Title</th>
<th>Author</th>
<th>Number of Pages</th>
<th>Pages</th>
<th>Read</th>
<th></th>
<th>Action</th>
</tr>
</thead>
<tbody>
<tr>
<td></td>
<td></td>
<td></td>
<td></td>
<td></td>
</tr>
</tbody>
<tbody></tbody>
</table>
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script>

<script src="script.js"></script>
</body>
Expand Down
134 changes: 59 additions & 75 deletions debugging/book-library/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,103 +1,87 @@
let myLibrary = [];

window.addEventListener("load", function (e) {
window.addEventListener("load", () => {
populateStorage();
render();
});

function populateStorage() {
if (myLibrary.length == 0) {
let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
let book2 = new Book(
"The Old Man and the Sea",
"Ernest Hemingway",
"127",
true
);
myLibrary.push(book1);
myLibrary.push(book2);
render();
if (myLibrary.length === 0) {
myLibrary.push(new Book("Robinson Crusoe", "Daniel Defoe", 252, true));
myLibrary.push(new Book("The Old Man and the Sea", "Ernest Hemingway", 127, true));
}
}

const title = document.getElementById("title");
const author = document.getElementById("author");
const pages = document.getElementById("pages");
const check = document.getElementById("check");
const titleInput = document.getElementById("title");
const authorInput = document.getElementById("author");
const pagesInput = document.getElementById("pages");
const readCheckbox = document.getElementById("check");

//check the right input from forms and if its ok -> add the new book (object in array)
//via Book function and start render function
function submit() {
if (
title.value == null ||
title.value == "" ||
pages.value == null ||
pages.value == ""
) {
alert("Please fill all fields!");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
render();
const title = titleInput.value.trim();
const author = authorInput.value.trim();
const pages = Number(pagesInput.value);

if (!title || !author || !pagesInput.value) {
alert("Please fill all fields.");
return;
}

if (Number.isNaN(pages) || pages <= 0) {
alert("Page count must be a positive number.");
return;
}
Copy link
Contributor

@cjyuan cjyuan Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some invalid "number of pages" can still pass the check on line 30.


const book = new Book(title, author, pages, readCheckbox.checked);
myLibrary.push(book);
render();

titleInput.value = "";
authorInput.value = "";
pagesInput.value = "";
readCheckbox.checked = false;
}

function Book(title, author, pages, check) {
function Book(title, author, pages, read) {
this.title = title;
this.author = author;
this.pages = pages;
this.check = check;
this.read = read;
}

function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
table.deleteRow(n);
}
//insert updated row and cells
let length = myLibrary.length;
for (let i = 0; i < length; i++) {
let row = table.insertRow(1);
let titleCell = row.insertCell(0);
let authorCell = row.insertCell(1);
let pagesCell = row.insertCell(2);
let wasReadCell = row.insertCell(3);
let deleteCell = row.insertCell(4);
titleCell.innerHTML = myLibrary[i].title;
authorCell.innerHTML = myLibrary[i].author;
pagesCell.innerHTML = myLibrary[i].pages;
const table = document.getElementById("display");
const tbody = table.tBodies[0];

// Clear table efficiently
tbody.innerHTML = "";

myLibrary.forEach((book, index) => {
const row = tbody.insertRow();

//add and wait for action for read/unread button
let changeBut = document.createElement("button");
changeBut.id = i;
changeBut.className = "btn btn-success";
wasReadCell.appendChild(changeBut);
let readStatus = "";
if (myLibrary[i].check == false) {
readStatus = "Yes";
} else {
readStatus = "No";
}
changeBut.innerText = readStatus;
row.insertCell().textContent = book.title;
row.insertCell().textContent = book.author;
row.insertCell().textContent = book.pages;

changeBut.addEventListener("click", function () {
myLibrary[i].check = !myLibrary[i].check;
const readCell = row.insertCell();
Copy link
Contributor

@cjyuan cjyuan Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you think of the pros and cons of these two approaches for creating cells within a row?

  • Keeping all the cell creation code in one location, like what the original code does.
  • Scattering the cell creation code across different locations, like what you did.

Copy link
Author

@Alaa-Tagi Alaa-Tagi Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Keeping all cell creation code in one place make the structure easier to read and maintain, while scattering the code can make each part easier to manage but can also make the table setup less clear.

const toggleReadBtn = document.createElement("button");
toggleReadBtn.className = "btn btn-success";
toggleReadBtn.textContent = book.read ? "Yes" : "No";
toggleReadBtn.addEventListener("click", () => {
book.read = !book.read;
render();
});
readCell.appendChild(toggleReadBtn);

//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
myLibrary.splice(i, 1);
const deleteCell = row.insertCell();
const deleteBtn = document.createElement("button");
deleteBtn.className = "btn btn-warning";
deleteBtn.textContent = "Delete";
deleteBtn.addEventListener("click", () => {
myLibrary.splice(index, 1); // delete first
render();
alert(`Deleted book: ${book.title}`); // then notify
});
}
}
deleteCell.appendChild(deleteBtn);
});
}
15 changes: 8 additions & 7 deletions debugging/book-library/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,20 @@
.form-group {
width: 400px;
height: 300px;
align-self: left;
padding-left: 20px;
}

button.btn-info {
margin: 20px;
}

.btn {
display: block;
width: fit-content;
}

.form-check-label {
padding-left: 20px;
margin: 5px 0px 5px 0px;
margin-left: 5px;
}

button.btn-info {
margin: 20px;
table {
margin-top: 20px;
}