West Midlands | ITP-Sept-25 | Georgina Rogers | Sprint 1 | Destructuring #347
Conversation
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Wrong number of parts separated by |s If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
zilinskyte
changed the title
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
4 similar comments
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
zilinskyte
added
📅 Sprint 1
sambabib
added
Review in progress
| Gryffindors.push(`${person["firstName"]} ${person.lastName}`); | ||
| } | ||
| } | ||
| return Gryffindors; |
There was a problem hiding this comment.
This solution returns the Gryffindors array, which is good. However, the exercise asks that you return the first and last names. This function will only return the names in an array, like so: [“Harry Potter”, “Ron Weasley”…], you would want to convert the contents of the array to individual strings. How do you reckon you can achieve this?
|
|
||
| function getReceipt(order) { | ||
| let total = 0; | ||
| let receiptLines = ["QTY ITEM TOTAL"]; |
There was a problem hiding this comment.
Please talk to me about the spacing here? Item and Total appear to be a single string “Item Total” with loads of spacing in the array definition.
There was a problem hiding this comment.
I made the spacing in order for the headings to align with the table below when it prints in the terminal. Is there a better way to do this?
| receiptLines.push(`TOTAL: ${(total / 100).toFixed(2)}`); | ||
| return receiptLines.join('\n'); | ||
| } | ||
| console.log(getReceipt(order)); |
There was a problem hiding this comment.
The exercise also requires that you log each item and the total cost of the order. I don’t believe you have done that in your solution here. Do you want to revisit the instructions from the exercise?
There was a problem hiding this comment.
For me the table prints successfully in the terminal and looks exactly as in the instructions of the exercise
There was a problem hiding this comment.
When logging the order, all items print with the quantity and price, do i need to log them in a different way, or one by one?
sambabib
added
Reviewed
2 participants
Learners, PR Template
Self checklist
Changelist
Bugs addressed
Questions
.