NW6|Bakhat Begum| Module.JS-1| Bakhat/week 4|Sprint-4|Week-4 #178

BakhatBegum · 2023-12-01T12:32:16Z

Self checklist

I have committed my files one by one, on purpose, and for a reason
I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
I have tested my changes
My changes meet the requirements of this task

Questions

I would like to receive feedback.

…function

musayuksel

Hey @BakhatBegum ! 👋 I took a look at them, and I have some feedback to share. While you made an effort, there are some areas where improvements can be made. I believe with a bit more attention to detail and some additional practice, you'll be able to enhance your solutions. If you have any questions or need further assistance, please don't hesitate to reach out. I'm here to help and support you in your learning journey. Keep up the good work!

musayuksel · 2023-12-02T21:27:57Z

week-1/errors/3.js

 // The last4Digits variable should store the last 4 digits of cardNumber
 // However, the code isn't working
 // Make and explain a prediction about why the code won't work
+//ans: I think we use .slice method for string. According to me, .toFixed() method will work on card. The method .toFixed() is used for numerical values .


Your solution is correct. For clarification, the toFixed() method you mentioned is used to format numbers with a specific number of decimal places. You can check the mdn https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/toFixed

musayuksel · 2023-12-02T22:03:29Z

week-4/implement/count.js

+function countChar(str, char ){
+if (/[A-Z]/.test(str)) {
+        return 0;
+    }else if (str.repeat(char) !== '') {
+        return str.repeat(char);
+    }
+}
+console.log(countChar('Bgft', 3)) 
+
+module.exports = countChar;
+


The regular expression test if (/[A-Z]/.test(str)) checks for the presence of uppercase letters in the string str, which is not in line with the requirements. Instead, the function should count the occurrences of a specific character char within the string. Consider modifying this condition to check for the desired character instead of uppercase letters.
The usage of str.repeat(char) is incorrect. The repeat() method is used to repeat a string a certain number of times, but in this context, char should represent a single character to search for, not the number of repetitions. You'll need to adjust the approach to accurately count the occurrences of the specified character.
To improve the solution, I would suggest using a loop to iterate over each character in the string str. Inside the loop, compare each character with the specified character char and increment a count variable when there is a match. Finally, return the total count.
if you need any help please let me know.

musayuksel · 2023-12-02T22:09:36Z

week-4/implement/get-ordinal-number.js

@@ -0,0 +1,21 @@
+function getOrdinalNumber(num){
+	var ordinal = +num.toString().split('').pop();


This line converts the number to a string, splits it into an array of individual digits, and then takes the last digit as the ordinal. This approach is problematic because it doesn't handle numbers greater than 9 correctly. For example, if num is 11, the resulting ordinal will be 1, which is incorrect. Also. we recommend using let or const instead of the var keyword. It is not recommended to use var.

musayuksel · 2023-12-02T22:10:44Z

week-4/implement/get-ordinal-number.test.js

@@ -1,4 +1,13 @@
 // In this week's prep, we started implementing getOrdinalNumber

+const getOrdinalNumber = require("./get-ordinal-number");


Try to implement more test cases for different scenarios

musayuksel · 2023-12-02T22:13:47Z

week-4/implement/is-prime.js

+        }
+         return true;
+}
+// console.log(isPrime(17));


The solution provided is great! It successfully checks if a given number is prime. To further improve the code, I would suggest using clear and descriptive variable names instead of abbreviations like "sq".

musayuksel · 2023-12-02T22:16:43Z

week-4/implement/password-validator.js

@@ -0,0 +1,30 @@
+function passwordValidator(password,oldPassword){
+    if (password.length >= 5){


The condition if (password.length >= 5) is checking if the password length is greater than or equal to 5. However, the requirement is to check if the password has at least 5 characters.

musayuksel · 2023-12-02T22:19:46Z

week-4/implement/password-validator.js

@@ -0,0 +1,30 @@
+function passwordValidator(password,oldPassword){


You should pass one argument and the function should validate it.

musayuksel · 2023-12-02T22:24:51Z

week-4/implement/password-validator.js

@@ -0,0 +1,30 @@
+function passwordValidator(password,oldPassword){
+    if (password.length >= 5){
+        return false;


More importantly, as mentioned in the question, it is crucial to break down the problem into smaller steps to solve it effectively.

Begin by writing a function that checks if the password is longer than 5 characters.

Focus on passing the tests for this specific requirement before moving on to the next step.

Once the first step is working correctly, proceed to the second step and implement a function to validate the presence of an uppercase letter.

Again, ensure that this step passes the tests.

Repeat this process for each subsequent requirement: checking for a lowercase letter, a number, a non-alphanumeric symbol, and ensuring the password is not in the list of previous passwords.

musayuksel · 2023-12-02T22:28:41Z

week-4/implement/repeat.test.js

+
+test("When the repeat function is called with o inputs, then it should return empty string.", () => {
+
+    expect(repeat("eff", 0)).toBe();


In this test, should check ...toBe('')

case: Handle Count of 0:
// Given a target string str and a count equal to 0,
// When the repeat function is called with these inputs,
// Then it should return an empty string, ensuring that a count of 0 results in an empty output.

musayuksel · 2023-12-02T22:29:49Z

week-4/implement/repeat.js

+else if (str.repeat(count) !== '') {
+        return str.repeat(count);
+}
+return ;


As I explained below, this should return an empty string instead of undefined.

Sabella-8

I have seen a lot of progress, well done!

Sabella-8 · 2023-12-01T21:11:56Z

week-4/implement/count.test.js

I think the task is to count the repeated characters, not simply to repeat them as you mentioned in your test description. For example: When the function is called with these inputs,Then it should correctly count consecutive occurrences of char (e.g., 'a' appears five times in 'aaaaa\

Sabella-8 · 2023-12-01T21:14:24Z

week-4/implement/get-ordinal-number.js

Great work!

Sabella-8 · 2023-12-01T21:15:02Z

week-4/implement/is-prime.js

Sabella-8 · 2023-12-01T21:19:16Z

week-4/implement/password-validator.js

in line 2, if the password length >= 5 should print true because we want the password length to be >=5. Same in line 11 we want the password to include special characters so it should return true.

Sabella-8 · 2023-12-01T21:20:03Z

week-4/implement/repeat.js

Sabella-8 · 2023-12-01T21:20:36Z

week-4/investigate/find.js

Good explanation

Sabella-8 · 2023-12-01T22:25:32Z

week-4/implement/credit-card-validator.js

Sabella-8 · 2024-01-03T15:50:32Z

week-4/implement/count.js

Sabella-8 · 2024-01-03T15:51:55Z

week-4/implement/credit-card-validator.js

you used a lot of new codes, which is good.

Sabella-8 · 2024-01-03T15:53:08Z

week-4/implement/get-ordinal-number.js

vboxuser and others added 30 commits November 6, 2023 18:52

added command and variables

6813bfc

added variable, working with Math.floor, Math.roound,Math.random and …

49d40f7

…function

working on file

c85d42b

working on a file path

dda5f90

for update

0c65f52

working on BMI

ba7225d

working with toUppercase and white space

88cc3c6

Prediction and explanation with output results

7af8cc5

have worked on argument and function parameter.

e4f4ad5

I have worked on function, variable, Math.floor, Math.round and toFixed

fdee53e

calling funtion

f52f53f

update code

ae50334

next solution

addc187

multiplying price

2591330

working on assertion

0e678b1

working on angle

5e757d5

added condition

646bb10

working on fraction

c985e13

function to return triangle

569154a

fraction output

9b7c15a

condition for fraction

5d5b75a

store expression in new variable.

3e5f474

working on Unicode character

df15012

understanding code and try to figure out my error.

ba3a263

changed return value

4b5f604

debug errors

569c6fd

some codes were deleted my mistakes

71954f9

added some lines of code

f115c6f

Because of software I lost my codes and rewrite code again.

984afdf

added variable

9814ace

BakhatBegum added 14 commits November 27, 2023 14:13

added test.json file.

a713454

working on count file.

8c6dc69

added test case on count.js

0d9a980

created function for validator file.

8ec4c33

working of if condition.

ad14052

working on case test.

7c64157

added code on function body.

c254fad

added test case on is-prime.test.js file

e3a5e12

where was an error on code.

fc8fe13

added for loop

45badd5

added answer to given questions.

438db85

added index in loop.

53fb6de

added code on how to return 0 if there is any capital letter in string.

067e144

added code

91083b5

musayuksel suggested changes Dec 2, 2023

View reviewed changes

addded changes

f851252

BakhatBegum mentioned this pull request Dec 6, 2023

[TECH ED] Complete week 4 exercises BakhatBegum/My-Coursework-Planner#49

Open

BakhatBegum and others added 10 commits December 9, 2023 12:29

changed var to let

d67c88f

To find the frequency of a string, I have used a forEach loop.

4c6d858

The variable has been updated from 'var' to 'let'.

ebc1869

The test case order has been changed.

ca44437

changed variable name sq to squareRoot

f32d7ad

added more test case

9dd4e73

there was a mistake on if statement

fe1341b

added test case

7289ea9

I have rewritten the code using a loop.

e407d93

Update 3.js

2a1cca5

Sabella-8 reviewed Jan 3, 2024

View reviewed changes

Sabella-8 mentioned this pull request Jan 3, 2024

[TECH ED] Code review Sabella-8/My-Coursework-Planner#77

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NW6|Bakhat Begum| Module.JS-1| Bakhat/week 4|Sprint-4|Week-4 #178

NW6|Bakhat Begum| Module.JS-1| Bakhat/week 4|Sprint-4|Week-4 #178

BakhatBegum commented Dec 1, 2023 •

edited

Loading

musayuksel left a comment

musayuksel Dec 2, 2023

musayuksel Dec 2, 2023

musayuksel Dec 2, 2023

musayuksel Dec 2, 2023

musayuksel Dec 2, 2023

musayuksel Dec 2, 2023

musayuksel Dec 2, 2023

musayuksel Dec 2, 2023

musayuksel Dec 2, 2023

musayuksel Dec 2, 2023

Sabella-8 left a comment

Sabella-8 Dec 1, 2023

Sabella-8 Dec 1, 2023

Sabella-8 Dec 1, 2023

Sabella-8 Dec 1, 2023

Sabella-8 Dec 1, 2023

Sabella-8 Dec 1, 2023

Sabella-8 Dec 1, 2023

Sabella-8 Jan 3, 2024

Sabella-8 Jan 3, 2024

Sabella-8 Jan 3, 2024

		@@ -0,0 +1,21 @@
		function getOrdinalNumber(num){
		var ordinal = +num.toString().split('').pop();

		@@ -1,4 +1,13 @@
		// In this week's prep, we started implementing getOrdinalNumber

		const getOrdinalNumber = require("./get-ordinal-number");

		@@ -0,0 +1,30 @@
		function passwordValidator(password,oldPassword){
		if (password.length >= 5){


		test("When the repeat function is called with o inputs, then it should return empty string.", () => {

		expect(repeat("eff", 0)).toBe();

NW6|Bakhat Begum| Module.JS-1| Bakhat/week 4|Sprint-4|Week-4 #178

Are you sure you want to change the base?

NW6|Bakhat Begum| Module.JS-1| Bakhat/week 4|Sprint-4|Week-4 #178

Conversation

BakhatBegum commented Dec 1, 2023 • edited Loading

Questions

musayuksel left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Sabella-8 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BakhatBegum commented Dec 1, 2023 •

edited

Loading